Enable linters explicitly instead of using ament_lint_common

This gives more control over which linters are run. For example, we don't need to depend on Python linters for many packages.
This commit also worksaround an upstream issue with CI, where ament_cmake_flake8 is currently failing with a Dashing installation
if flake8 is installed from pip. See ament/ament_lint#252 for a fix upstream.

Signed-off-by: Jacob Perron <[email protected]>

Author: jacobperron

ament_cmake_export_jars/package.xml

@@ -18,8 +18,10 @@
   <build_depend>ament_java_resources</build_depend>
   <exec_depend>ament_java_resources</exec_depend>
 
+  <test_depend>ament_cmake_copyright</test_depend>
+  <test_depend>ament_cmake_lint_cmake</test_depend>
+  <test_depend>ament_cmake_xmllint</test_depend>
   <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
 
   <export>
     <build_type>ament_cmake</build_type>

ament_cmake_export_jni_libraries/package.xml

@@ -18,8 +18,10 @@
   <build_depend>ament_java_resources</build_depend>
   <exec_depend>ament_java_resources</exec_depend>
 
+  <test_depend>ament_cmake_copyright</test_depend>
+  <test_depend>ament_cmake_lint_cmake</test_depend>
+  <test_depend>ament_cmake_xmllint</test_depend>
   <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
 
   <export>
     <build_type>ament_cmake</build_type>

rcljava/package.xml

@@ -34,8 +34,12 @@
   <exec_depend>rosidl_generator_c</exec_depend>
   <exec_depend>rosidl_parser</exec_depend>
 
+  <test_depend>ament_cmake_copyright</test_depend>
+  <test_depend>ament_cmake_cppcheck</test_depend>
+  <test_depend>ament_cmake_lint_cmake</test_depend>
+  <test_depend>ament_cmake_uncrustify</test_depend>
+  <test_depend>ament_cmake_xmllint</test_depend>
   <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
   <test_depend>builtin_interfaces</test_depend>
   <test_depend>rcl_interfaces</test_depend>
   <test_depend>rcljava_common</test_depend>

rcljava_common/package.xml

@@ -12,8 +12,12 @@
   <buildtool_depend>ament_cmake_export_libraries</buildtool_depend>
   <buildtool_export_depend>rosidl_cmake</buildtool_export_depend>
 
+  <test_depend>ament_cmake_copyright</test_depend>
+  <test_depend>ament_cmake_cppcheck</test_depend>
+  <test_depend>ament_cmake_lint_cmake</test_depend>
+  <test_depend>ament_cmake_uncrustify</test_depend>
+  <test_depend>ament_cmake_xmllint</test_depend>
   <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
 
   <export>
     <build_type>ament_cmake</build_type>

rosidl_generator_java/package.xml

@@ -27,9 +27,16 @@
   <exec_depend>rosidl_generator_c</exec_depend>
   <exec_depend>rosidl_parser</exec_depend>
 
+  <test_depend>ament_cmake_copyright</test_depend>
+  <test_depend>ament_cmake_cppcheck</test_depend>
+  <!-- TODO(jacobperron): Re-enable after https://github.com/ament/ament_lint/pull/252 -->
+  <!--test_depend>ament_cmake_flake8</test_depend-->
   <test_depend>ament_cmake_gtest</test_depend>
+  <test_depend>ament_cmake_lint_cmake</test_depend>
+  <test_depend>ament_cmake_pep257</test_depend>
+  <test_depend>ament_cmake_uncrustify</test_depend>
+  <test_depend>ament_cmake_xmllint</test_depend>
   <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_lint_common</test_depend>
 
   <test_depend>rmw_implementation</test_depend>
   <test_depend>rmw_implementation_cmake</test_depend>