Skip to content

Commit 197c82e

Browse files
authored
[Backport Dashing] Fixed doxygen warnings (#677) (#702)
Signed-off-by: ahcorde <[email protected]>
1 parent 608233c commit 197c82e

File tree

9 files changed

+16
-10
lines changed

9 files changed

+16
-10
lines changed

rcl/include/rcl/event.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ rcl_subscription_event_init(
103103
/**
104104
* Take an event from the event handle.
105105
*
106-
* \param[in] event_handle event object to take from
106+
* \param[in] event event object to take from
107107
* \param[in, out] event_info event info object to write taken data into
108108
* \param[in, out] taken boolean flag indicating if an event was taken or not
109109
* \return `RCL_RET_OK` if successful, or

rcl/include/rcl/graph.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,8 @@ rcl_names_and_types_fini(rcl_names_and_types_t * names_and_types);
361361
*
362362
* \param[in] node the handle to the node being used to query the ROS graph
363363
* \param[in] allocator used to control allocation and deallocation of names
364-
* \param[out] node_names struct storing discovered node names.
365-
* \param[out] node_namesspaces struct storing discovered node namespaces.
364+
* \param[out] node_names struct storing discovered node names
365+
* \param[out] node_namespaces struct storing discovered node namespaces
366366
* \return `RCL_RET_OK` if the query was successful, or
367367
* \return `RCL_RET_ERROR` if an unspecified error occurs.
368368
*/

rcl/include/rcl/logging_rosout.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,8 @@ rcl_logging_rosout_fini_publisher_for_node(
152152
* \param[in] severity The severity level
153153
* \param[in] name The name of the logger, must be null terminated c string
154154
* \param[in] timestamp The timestamp for when the log message was made
155-
* \param[in] log_str The string to be logged
155+
* \param[in] format The list of arguments to insert into the formatted log message
156+
* \param[in] args argument for the string format
156157
*/
157158
RCL_PUBLIC
158159
void rcl_logging_rosout_output_handler(

rcl/include/rcl/node_options.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ rcl_node_options_copy(
110110
* Uses Atomics | Yes
111111
* Lock-Free | Yes
112112
*
113-
* \param[inout] node_options object to be finalized
113+
* \param[inout] options object to be finalized
114114
* \return `RCL_RET_OK` if setup is successful, or
115115
* \return `RCL_RET_INVALID_ARGUMENT` if any arguments are invalid, or
116116
* \return `RCL_RET_ERROR` if an unspecified error occurs.

rcl/include/rcl/remap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ rcl_remap_node_namespace(
257257
* Uses Atomics | No
258258
* Lock-Free | Yes
259259
*
260-
* \param[in] args The structure to be deallocated.
260+
* \param[in] remap The structure to be deallocated.
261261
* \return `RCL_RET_OK` if the memory was successfully freed, or
262262
* \return `RCL_RET_INVALID_ARGUMENT` if any function arguments are invalid, or
263263
* \return `RCL_RET_ERROR` if an unspecified error occurs.

rcl/include/rcl/validate_topic_name.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,10 @@ rcl_validate_topic_name(
9797
/// Validate a given topic name.
9898
/**
9999
* This is an overload with an extra parameter for the length of topic_name.
100+
* \param[in] topic_name the topic name to be validated, must be null terminated
100101
* \param[in] topic_name_length The number of characters in topic_name.
102+
* \param[out] validation_result the reason for validation failure, if any
103+
* \param[out] invalid_index index of violation if the input topic is invalid
101104
*
102105
* \sa rcl_validate_topic_name(const char *, int *, size_t *)
103106
*/

rcl_action/include/rcl_action/action_client.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ rcl_action_send_result_request(
548548
*
549549
* \param[in] action_client handle to the client that will take the result response
550550
* \param[out] response_header pointer to the result response header
551-
* \param[out] ros_result_response preallocated, zero-initialized, struct where the ROS
551+
* \param[out] ros_result preallocated, zero-initialized, struct where the ROS
552552
* result message is copied.
553553
* \return `RCL_RET_OK` if the response was taken successfully, or
554554
* \return `RCL_RET_INVALID_ARGUMENT` if any arguments are invalid, or
@@ -639,7 +639,7 @@ rcl_action_send_cancel_request(
639639
* Lock-Free | Yes
640640
*
641641
* \param[in] action_client handle to the client that will take the cancel response
642-
* \param[out] request_header pointer to the cancel response header
642+
* \param[out] response_header pointer to the cancel response header
643643
* \param[out] ros_cancel_response a zero-initialized ROS cancel response message where
644644
* the cancel response is copied.
645645
* \return `RCL_RET_OK` if the response was taken successfully, or

rcl_action/include/rcl_action/action_server.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -712,7 +712,7 @@ rcl_action_take_cancel_request(
712712
*
713713
* \param[in] action_server handle to the action server that will process the cancel request
714714
* \param[in] cancel_request a C-typed ROS cancel request to process
715-
* \param[out] cancel_reponse a zero-initialized cancel response struct
715+
* \param[out] cancel_response a zero-initialized cancel response struct
716716
* where the goal info of goals which should be cancelled are copied
717717
* \return `RCL_RET_OK` if the response was sent successfully, or
718718
* \return `RCL_RET_INVALID_ARGUMENT` if any arguments are invalid, or

rcl_action/include/rcl_action/wait.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,11 @@ rcl_action_server_wait_set_get_num_entities(
208208
* Uses Atomics | No
209209
* Lock-Free | Yes
210210
*
211+
* \param[in] wait_set struct where action server services are to be stored
211212
* \param[in] action_client an action client to query
212213
* \param[out] is_feedback_ready `true` if there is a feedback message ready to take,
213214
* `false` otherwise
214-
* \param[out] is_status_message `true` if there is a status message ready to take,
215+
* \param[out] is_status_ready `true` if there is a status message ready to take,
215216
* `false` otherwise
216217
* \param[out] is_goal_response_ready `true` if there is a goal response message ready
217218
* to take, `false` otherwise
@@ -251,6 +252,7 @@ rcl_action_client_wait_set_get_entities_ready(
251252
* Uses Atomics | No
252253
* Lock-Free | Yes
253254
*
255+
* \param[in] wait_set struct where action server services are to be stored
254256
* \param[in] action_server an action server to query
255257
* \param[out] is_goal_request_ready `true` if there is a goal request message ready
256258
* to take, `false` otherwise

0 commit comments

Comments
 (0)