Skip to content

Mobile view + optin headroom #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mobile view + optin headroom #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b484ae
Mobile view + optin headroom
ColinFay Oct 14, 2020
c9a4bb2
new mobile view with stacked buttons
ColinFay Nov 4, 2020
29d051c
This adds a close button on hints & solutions
ColinFay Nov 4, 2020
2b3d74c
new handling of progress bar
ColinFay Nov 13, 2020
96571bc
That should make R CMD check happy
ColinFay Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions R/html-dependencies.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,12 @@ ace_html_dependency <- function() {
script = "ace.js"
)
}

headroom_html_dependency <- function() {
htmltools::htmlDependency(
name = "headroom",
version = "0.11.0",
src = system.file("lib/headroom", package = "learnr"),
script = "headroom.js"
)
}
5 changes: 5 additions & 0 deletions R/tutorial-format.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#' @param smart Produce typographically correct output, converting straight quotes to curly quotes,
#' \code{---} to em-dashes, \code{--} to en-dashes, and \code{...} to ellipses.
#' Deprecated in \pkg{rmarkdown} v2.2.0.
#' @param with_headroom Should the menu be dynamically hidden when the user scroll? Defaults to \code{FALSE}.
#' @param ... Forward parameters to html_document
#'
#' @export
Expand All @@ -45,6 +46,7 @@ tutorial <- function(fig_width = 6.5,
includes = NULL,
md_extensions = NULL,
pandoc_args = NULL,
with_headroom = FALSE,
...) {

# base pandoc options
Expand Down Expand Up @@ -103,6 +105,9 @@ tutorial <- function(fig_width = 6.5,
tutorial_html_dependency(),
tutorial_autocompletion_html_dependency(),
tutorial_diagnostics_html_dependency(),
{
if (with_headroom) headroom_html_dependency()
},
htmltools::htmlDependency(
name = "tutorial-format",
version = utils::packageVersion("learnr"),
Expand Down
Loading