RB-423 removing unnecessary data structures #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduarduseldorf
changed the title
rcarcasses
reviewed
Nov 7, 2025
| } | ||
| } | ||
| } | ||
| } |
rcarcasses
reviewed
Nov 7, 2025
| void receive_data(std::unique_ptr<BaseMessage> msg, size_t port_index) override { | ||
| try { | ||
| Operator::receive_data(std::move(msg), port_index); | ||
| Operator::receive_data(std::move(msg), port_index); |
Contributor
There was a problem hiding this comment.
not real change on this file but bad formatting
rcarcasses
reviewed
Nov 7, 2025
| class Operator { | ||
| public: | ||
| Operator(std::string id) : id_(std::move(id)) {} | ||
| Operator(std::string id) : id_(std::move(id)), max_size_per_port_(17280) {} |
Contributor
There was a problem hiding this comment.
remove hard coded 17280, use #define MAX_SIZE_PER_PORT 10000 or similar.
rcarcasses
reviewed
Nov 7, 2025
| } | ||
| demux->execute(); | ||
|
|
||
| THEN("Message is routed to both ports") { |
Contributor
There was a problem hiding this comment.
I'm not sure this is the behaviour we want.
rcarcasses
reviewed
Nov 7, 2025
|
|
||
| double get_default_value() const { return default_value_; } | ||
|
|
||
| Bytes collect() override { |
Contributor
There was a problem hiding this comment.
I believe we need this serialization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.