Skip to content

Commit eea4c90

Browse files
22quinnzhuohan123
authored andcommitted
[Core] Enable async scheduling for external_launcher mode (vllm-project#27394)
Signed-off-by: 22quinn <[email protected]> Co-authored-by: Zhuohan Li <[email protected]>
1 parent 5b8a535 commit eea4c90

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

vllm/engine/arg_utils.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1553,11 +1553,12 @@ def create_engine_config(
15531553
)
15541554

15551555
if self.async_scheduling and (
1556-
parallel_config.distributed_executor_backend not in ("mp", "uni")
1556+
parallel_config.distributed_executor_backend
1557+
not in ("mp", "uni", "external_launcher")
15571558
):
15581559
raise ValueError(
1559-
"Currently, async scheduling only supports `mp` or `uni` "
1560-
"distributed executor backend, but you choose "
1560+
"Currently, async scheduling only supports `mp`, `uni` or "
1561+
"`external_launcher` distributed executor backend, but you choose "
15611562
f"`{parallel_config.distributed_executor_backend}`."
15621563
)
15631564

vllm/v1/engine/llm_engine.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,7 @@ def step(self) -> list[RequestOutput] | list[PoolingRequestOutput]:
306306
self.engine_core.abort_requests(processed_outputs.reqs_to_abort)
307307

308308
# 4) Record stats
309-
if self.logger_manager is not None:
310-
assert outputs.scheduler_stats is not None
311-
309+
if self.logger_manager is not None and outputs.scheduler_stats is not None:
312310
self.logger_manager.record(
313311
scheduler_stats=outputs.scheduler_stats,
314312
iteration_stats=iteration_stats,

0 commit comments

Comments
 (0)