Merge pull request #74 from runk/fix-logger

Fix logger

Author: runk

.gitignore

@@ -1,2 +1,3 @@
 node_modules
 cache/*
+*.log

.travis.yml

@@ -1,6 +1,5 @@
 language: node_js
 node_js:
-  - "4.8"
   - "6.9"
   - "8.4"
   - "10"

README.md

@@ -102,7 +102,7 @@ npm --proxy http://npm-proxy-cache:8080 --https-proxy http://npm-proxy-cache:808
 
 ## Limitations
 
- - Works only with node `4.9.1` and above.
+ - Works only with node `6` and above.
 
 
 ----

lib/logger.js

@@ -0,0 +1,19 @@
+'use strict';
+const log4js = require('log4js');
+
+module.exports = function(opts) {
+  const appenders = { stdout: { type: 'stdout' } };
+  if (opts.logPath) {
+    appenders.file = { type: 'file', filename: opts.logPath };
+  }
+
+  const categories = {
+    default: {
+      appenders: Object.keys(appenders),
+      level: opts.verbose ? 'debug' : 'info'
+    }
+  };
+
+  log4js.configure({ appenders, categories });
+  return log4js.getLogger();
+};

lib/proxy.js

@@ -7,8 +7,8 @@ const os = require('os');
 const url = require('url');
 const path = require('path');
 const request = require('request');
-const log4js = require('log4js');
 const Cache = require('./cache');
+const getLogger = require('./logger');
 
 
 // To avoid 'DEPTH_ZERO_SELF_SIGNED_CERT' error on some setups
@@ -39,14 +39,8 @@ exports.powerup = function(opts) {
     path: opts.storage, ttl: opts.ttl, friendlyNames: opts.friendlyNames
   });
 
-  if (opts.logPath) {
-    log4js.configure({
-      appenders: { 'proxy': { type: 'file', filename: opts.logPath } },
-      categories: { default: { appenders: ['proxy'], level: opts.verbose ? 'debug' : 'info' }}
-    });
-  }
-  
-  this.log = log4js.getLogger('proxy');
+
+  this.log = getLogger(opts);
 
   // Fake https server aka MITM
   const mitm = https.createServer(options, exports.httpHandler);