Have append_query_params take iterator over &strs

Author: tnull

bitreq/fuzz/src/url_parse.rs

@@ -86,7 +86,7 @@ pub fn do_test(data: &[u8]) {
             {
                 let mut url_clone = bitreq_url.clone();
                 // Use the input itself as both key and value to exercise encoding
-                url_clone.append_query_params([(input.to_string(), input.to_string())]);
+                url_clone.append_query_params([(&*input, &*input)]);
                 // Verify the URL is still valid by accessing its fields
                 let _ = url_clone.query();
                 let _ = url_clone.as_str();
@@ -98,10 +98,7 @@ pub fn do_test(data: &[u8]) {
 
                 // Test appending multiple params in one call
                 let mut url_clone3 = bitreq_url.clone();
-                url_clone3.append_query_params([
-                    ("key1".into(), "value1".into()),
-                    ("key2".into(), input.to_string()),
-                ]);
+                url_clone3.append_query_params([("key1", "value1"), ("key2", &input)]);
                 let _ = url_clone3.as_str();
             }
 

bitreq/src/request.rs

@@ -364,7 +364,8 @@ impl ParsedRequest {
     #[allow(unused_mut)]
     pub(crate) fn new(mut config: Request) -> Result<ParsedRequest, Error> {
         let mut url = Url::parse(&config.url)?;
-        url.append_query_params(config.params.drain(..));
+        let params = config.params.iter().map(|(a, b)| (a.as_str(), b.as_str()));
+        url.append_query_params(params);
 
         #[cfg(all(feature = "proxy", feature = "std"))]
         // Set default proxy from environment variables

bitreq/src/url.rs

@@ -418,7 +418,7 @@ impl Url {
     /// Otherwise, the first parameter is appended with `?`.
     ///
     /// Only calls `parse_inner` once after all parameters have been appended.
-    pub fn append_query_params(&mut self, params: impl IntoIterator<Item = (String, String)>) {
+    pub fn append_query_params<'a>(&mut self, params: impl IntoIterator<Item = (&'a str, &'a str)>) {
         let mut params = params.into_iter().peekable();
         if params.peek().is_none() {
             return;
@@ -1037,7 +1037,7 @@ mod tests {
     #[test]
     fn append_query_params_empty_iterator() {
         let mut url = Url::parse("http://example.com/path").unwrap();
-        url.append_query_params(std::iter::empty::<(String, String)>());
+        url.append_query_params(std::iter::empty::<(&str, &str)>());
         assert_eq!(url.query(), None);
         assert_eq!(url.as_str(), "http://example.com/path");
     }