Skip to content

Commit 1f49c8f

Browse files
Apply suggestions from code review
1 parent 89cc89b commit 1f49c8f

3 files changed

Lines changed: 6 additions & 7 deletions

File tree

‎examples/xilinx-zynq-a9/build.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//! # Build script for the Xilinx-Zynq-A9 !example.
1+
//! # Build script for the Xilinx-Zynq-A9 example.
22
//!
33
//! This script only executes when using `cargo` to build the project.
44

‎examples/xilinx-zynq-a9/src/lib.rs‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#![no_std]
22

3-
#[cfg(arm_architecture="v7-a")]
4-
pub mod mmu; // Include the mmu
3+
pub mod mmu;
54

65
static WANT_PANIC: portable_atomic::AtomicBool = portable_atomic::AtomicBool::new(false);
76

@@ -32,8 +31,7 @@ pub fn want_panic() {
3231

3332
/// Init the hardware
3433
///
35-
/// Includes enabling the MMU (if we have one)
36-
/// Supports ARMv7-a only #[cfg(arm_architecture = "v7-a")]
34+
/// Includes enabling the MMU.
3735
pub fn init() {
3836
mmu::set_mmu();
3937
mmu::enable_mmu_and_cache();

‎justfile‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,9 @@ test-qemu-v7a-zynq:
307307
FAIL=0
308308
./tests.sh examples/xilinx-zynq-a9 armv7a-none-eabi {{verbose}} --release || FAIL=1
309309
./tests.sh examples/xilinx-zynq-a9 armv7a-none-eabihf {{verbose}} --release || FAIL=1
310-
./tests.sh examples/xilinx-zynq-a9 thumbv7a-none-eabi {{verbose}} --release || FAIL=1
311-
if [ "${FAIL}" == "1" ]; then exit 1; fi
310+
./tests.sh examples/xilinx-zynq-a9 thumbv7a-none-eabi {{verbose}} --release || FAIL=1
311+
./tests.sh examples/xilinx-zynq-a9 thumbv7a-none-eabihf {{verbose}} --release || FAIL=1
312+
if [ "${FAIL}" == "1" ]; then exit 1; fi
312313

313314
test-qemu-v7r:
314315
#!/bin/bash

0 commit comments

Comments
 (0)