tests: Extract integration tests to separate compilation unit

This achieves the primary goal: modifying test files no longer triggers
library recompilation, significantly improving incremental test iteration.

Author: Turbo87

Cargo.toml

@@ -46,6 +46,10 @@ opt-level = 2
 name = "crates_io"
 doctest = true
 
+[[test]]
+name = "integration"
+path = "src/tests/mod.rs"
+
 [dependencies]
 aes-gcm = { version = "=0.10.3", features = ["std"] }
 anyhow = "=1.0.100"

src/index.rs

@@ -140,9 +140,9 @@ pub async fn index_metadata(
 mod tests {
     use super::*;
     use crate::schema::users;
-    use crate::tests::builders::{CrateBuilder, VersionBuilder};
     use chrono::{Days, Utc};
     use crates_io_test_db::TestDatabase;
+    use crates_io_test_utils::builders::{CrateBuilder, VersionBuilder};
     use insta::assert_json_snapshot;
 
     #[tokio::test]

src/lib.rs

@@ -42,8 +42,6 @@ pub mod sqs;
 pub mod ssh;
 pub mod storage;
 pub mod tasks;
-#[cfg(test)]
-pub mod tests;
 pub mod typosquat;
 pub mod util;
 pub mod worker;

src/tests/account_lock.rs

@@ -1,12 +1,12 @@
-use crate::tests::{TestApp, util::RequestHelper};
+use crate::{TestApp, util::RequestHelper};
 use chrono::{DateTime, Duration, Utc};
 use insta::assert_snapshot;
 
 const URL: &str = "/api/v1/me";
 const LOCK_REASON: &str = "test lock reason";
 
 async fn lock_account(app: &TestApp, user_id: i32, until: Option<DateTime<Utc>>) {
-    use crate::schema::users;
+    use crates_io::schema::users;
     use diesel::prelude::*;
     use diesel_async::RunQueryDsl;
 

src/tests/authentication.rs

@@ -1,8 +1,8 @@
-use crate::tests::TestApp;
-use crate::tests::util::{MockRequestExt, MockTokenUser, RequestHelper, Response};
+use crate::TestApp;
+use crate::util::{MockRequestExt, MockTokenUser, RequestHelper, Response};
 
-use crate::tests::builders::PublishBuilder;
-use crate::tests::util::encode_session_header;
+use crate::builders::PublishBuilder;
+use crate::util::encode_session_header;
 use http::{Method, StatusCode, header};
 use insta::assert_snapshot;
 

src/tests/blocked_routes.rs

@@ -1,5 +1,5 @@
-use crate::tests::builders::{CrateBuilder, VersionBuilder};
-use crate::tests::util::{RequestHelper, TestApp};
+use crate::builders::{CrateBuilder, VersionBuilder};
+use crate::util::{RequestHelper, TestApp};
 use http::StatusCode;
 
 #[tokio::test(flavor = "multi_thread")]

src/tests/categories.rs

@@ -1,5 +1,5 @@
-use crate::schema::categories;
 use claims::assert_ok;
+use crates_io::schema::categories;
 use crates_io_test_db::TestDatabase;
 use diesel::*;
 use diesel_async::{AsyncPgConnection, RunQueryDsl};
@@ -53,7 +53,7 @@ async fn sync_adds_new_categories() {
     let test_db = TestDatabase::new();
     let mut conn = test_db.async_connect().await;
 
-    crate::boot::categories::sync_with_connection(ALGORITHMS_AND_SUCH, &mut conn)
+    crates_io::boot::categories::sync_with_connection(ALGORITHMS_AND_SUCH, &mut conn)
         .await
         .unwrap();
 
@@ -66,10 +66,10 @@ async fn sync_removes_missing_categories() {
     let test_db = TestDatabase::new();
     let mut conn = test_db.async_connect().await;
 
-    crate::boot::categories::sync_with_connection(ALGORITHMS_AND_SUCH, &mut conn)
+    crates_io::boot::categories::sync_with_connection(ALGORITHMS_AND_SUCH, &mut conn)
         .await
         .unwrap();
-    crate::boot::categories::sync_with_connection(ALGORITHMS, &mut conn)
+    crates_io::boot::categories::sync_with_connection(ALGORITHMS, &mut conn)
         .await
         .unwrap();
 
@@ -82,10 +82,10 @@ async fn sync_adds_and_removes() {
     let test_db = TestDatabase::new();
     let mut conn = test_db.async_connect().await;
 
-    crate::boot::categories::sync_with_connection(ALGORITHMS_AND_SUCH, &mut conn)
+    crates_io::boot::categories::sync_with_connection(ALGORITHMS_AND_SUCH, &mut conn)
         .await
         .unwrap();
-    crate::boot::categories::sync_with_connection(ALGORITHMS_AND_ANOTHER, &mut conn)
+    crates_io::boot::categories::sync_with_connection(ALGORITHMS_AND_ANOTHER, &mut conn)
         .await
         .unwrap();
 
@@ -99,5 +99,5 @@ async fn test_real_categories() {
     let mut conn = test_db.async_connect().await;
 
     const TOML: &str = include_str!("../boot/categories.toml");
-    assert_ok!(crate::boot::categories::sync_with_connection(TOML, &mut conn).await);
+    assert_ok!(crates_io::boot::categories::sync_with_connection(TOML, &mut conn).await);
 }

src/tests/cors.rs

@@ -1,5 +1,5 @@
-use crate::tests::TestApp;
-use crate::tests::util::{MockRequestExt, RequestHelper};
+use crate::TestApp;
+use crate::util::{MockRequestExt, RequestHelper};
 use insta::assert_snapshot;
 
 #[tokio::test(flavor = "multi_thread")]

src/tests/dump_db.rs

@@ -1,7 +1,7 @@
-use crate::tests::builders::CrateBuilder;
-use crate::tests::util::TestApp;
-use crate::worker::jobs::DumpDb;
+use crate::builders::CrateBuilder;
+use crate::util::TestApp;
 use bytes::Buf;
+use crates_io::worker::jobs::DumpDb;
 use crates_io_worker::BackgroundJob;
 use flate2::read::GzDecoder;
 use insta::{assert_debug_snapshot, assert_snapshot};

src/tests/github_secret_scanning.rs

@@ -1,12 +1,12 @@
-use crate::tests::builders::CrateBuilder;
-use crate::tests::util::MockRequestExt;
-use crate::tests::util::insta::api_token_redaction;
-use crate::tests::{RequestHelper, TestApp};
-use crate::util::token::HashedToken;
-use crate::{models::ApiToken, schema::api_tokens};
+use crate::builders::CrateBuilder;
+use crate::util::MockRequestExt;
+use crate::util::insta::api_token_redaction;
+use crate::{RequestHelper, TestApp};
 use base64::{Engine as _, engine::general_purpose};
 use chrono::{TimeDelta, Utc};
 use claims::assert_ok;
+use crates_io::util::token::HashedToken;
+use crates_io::{models::ApiToken, schema::api_tokens};
 use crates_io_database::models::CrateOwner;
 use crates_io_database::models::trustpub::NewToken;
 use crates_io_database::schema::trustpub_tokens;