Skip to content

Commit 5c6637b

Browse files
committed
frontend: quote crate name
1 parent ab3cb54 commit 5c6637b

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

app/routes/crate.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ export default class CrateRoute extends Route {
2323
return crate;
2424
} catch (error) {
2525
if (error instanceof NotFoundError) {
26-
let title = `${crateName}: Crate not found`;
26+
let title = `'${crateName}': Crate not found`;
2727
this.router.replaceWith('catch-all', { transition, error, title });
2828
} else {
29-
let title = `${crateName}: Failed to load crate data`;
29+
let title = `'${crateName}': Failed to load crate data`;
3030
this.router.replaceWith('catch-all', { transition, error, title, tryAgain: true });
3131
}
3232
}

e2e/acceptance/crate-dependencies.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ test.describe('Acceptance | crate dependencies page', { tag: '@acceptance' }, ()
3434
await page.goto('/crates/foo/1.0.0/dependencies');
3535
await expect(page).toHaveURL('/crates/foo/1.0.0/dependencies');
3636
await expect(page.locator('[data-test-404-page]')).toBeVisible();
37-
await expect(page.locator('[data-test-title]')).toHaveText('foo: Crate not found');
37+
await expect(page.locator('[data-test-title]')).toHaveText(`'foo': Crate not found`);
3838
await expect(page.locator('[data-test-go-back]')).toBeVisible();
3939
await expect(page.locator('[data-test-try-again]')).toHaveCount(0);
4040
});

e2e/acceptance/crate.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ test.describe('Acceptance | crate page', { tag: '@acceptance' }, () => {
8181
await page.goto('/crates/nanomsg');
8282
await expect(page).toHaveURL('/crates/nanomsg');
8383
await expect(page.locator('[data-test-404-page]')).toBeVisible();
84-
await expect(page.locator('[data-test-title]')).toHaveText('nanomsg: Crate not found');
84+
await expect(page.locator('[data-test-title]')).toHaveText(`'nanomsg': Crate not found`);
8585
await expect(page.locator('[data-test-go-back]')).toBeVisible();
8686
await expect(page.locator('[data-test-try-again]')).toHaveCount(0);
8787
});

tests/acceptance/crate-dependencies-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ module('Acceptance | crate dependencies page', function (hooks) {
4646
await visit('/crates/foo/1.0.0/dependencies');
4747
assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies');
4848
assert.dom('[data-test-404-page]').exists();
49-
assert.dom('[data-test-title]').hasText('foo: Crate not found');
49+
assert.dom('[data-test-title]').hasText(`'foo': Crate not found`);
5050
assert.dom('[data-test-go-back]').exists();
5151
assert.dom('[data-test-try-again]').doesNotExist();
5252
});

tests/acceptance/crate-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ module('Acceptance | crate page', function (hooks) {
8787
await visit('/crates/nanomsg');
8888
assert.strictEqual(currentURL(), '/crates/nanomsg');
8989
assert.dom('[data-test-404-page]').exists();
90-
assert.dom('[data-test-title]').hasText('nanomsg: Crate not found');
90+
assert.dom('[data-test-title]').hasText(`'nanomsg': Crate not found`);
9191
assert.dom('[data-test-go-back]').exists();
9292
assert.dom('[data-test-try-again]').doesNotExist();
9393
});

tests/routes/crate/range-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ module('Route | crate.range', function (hooks) {
8484
await visit('/crates/foo/range/^3');
8585
assert.strictEqual(currentURL(), '/crates/foo/range/%5E3');
8686
assert.dom('[data-test-404-page]').exists();
87-
assert.dom('[data-test-title]').hasText('foo: Crate not found');
87+
assert.dom('[data-test-title]').hasText(`'foo': Crate not found`);
8888
assert.dom('[data-test-go-back]').exists();
8989
assert.dom('[data-test-try-again]').doesNotExist();
9090
});

0 commit comments

Comments
 (0)