Skip to content

Commit b5134f1

Browse files
committed
frontend: add quote to crate name
1 parent ab3cb54 commit b5134f1

File tree

7 files changed

+13
-13
lines changed

7 files changed

+13
-13
lines changed

app/routes/crate.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ export default class CrateRoute extends Route {
2323
return crate;
2424
} catch (error) {
2525
if (error instanceof NotFoundError) {
26-
let title = `${crateName}: Crate not found`;
26+
let title = `'${crateName}': Crate not found`;
2727
this.router.replaceWith('catch-all', { transition, error, title });
2828
} else {
29-
let title = `${crateName}: Failed to load crate data`;
29+
let title = `'${crateName}': Failed to load crate data`;
3030
this.router.replaceWith('catch-all', { transition, error, title, tryAgain: true });
3131
}
3232
}

e2e/acceptance/crate-dependencies.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ test.describe('Acceptance | crate dependencies page', { tag: '@acceptance' }, ()
3434
await page.goto('/crates/foo/1.0.0/dependencies');
3535
await expect(page).toHaveURL('/crates/foo/1.0.0/dependencies');
3636
await expect(page.locator('[data-test-404-page]')).toBeVisible();
37-
await expect(page.locator('[data-test-title]')).toHaveText('foo: Crate not found');
37+
await expect(page.locator('[data-test-title]')).toHaveText(`'foo': Crate not found`);
3838
await expect(page.locator('[data-test-go-back]')).toBeVisible();
3939
await expect(page.locator('[data-test-try-again]')).toHaveCount(0);
4040
});
@@ -45,7 +45,7 @@ test.describe('Acceptance | crate dependencies page', { tag: '@acceptance' }, ()
4545
await page.goto('/crates/foo/1.0.0/dependencies');
4646
await expect(page).toHaveURL('/crates/foo/1.0.0/dependencies');
4747
await expect(page.locator('[data-test-404-page]')).toBeVisible();
48-
await expect(page.locator('[data-test-title]')).toHaveText('foo: Failed to load crate data');
48+
await expect(page.locator('[data-test-title]')).toHaveText(`'foo': Failed to load crate data'`);
4949
await expect(page.locator('[data-test-go-back]')).toHaveCount(0);
5050
await expect(page.locator('[data-test-try-again]')).toBeVisible();
5151
});

e2e/acceptance/crate.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ test.describe('Acceptance | crate page', { tag: '@acceptance' }, () => {
8181
await page.goto('/crates/nanomsg');
8282
await expect(page).toHaveURL('/crates/nanomsg');
8383
await expect(page.locator('[data-test-404-page]')).toBeVisible();
84-
await expect(page.locator('[data-test-title]')).toHaveText('nanomsg: Crate not found');
84+
await expect(page.locator('[data-test-title]')).toHaveText(`'nanomsg': Crate not found`);
8585
await expect(page.locator('[data-test-go-back]')).toBeVisible();
8686
await expect(page.locator('[data-test-try-again]')).toHaveCount(0);
8787
});
@@ -92,7 +92,7 @@ test.describe('Acceptance | crate page', { tag: '@acceptance' }, () => {
9292
await page.goto('/crates/nanomsg');
9393
await expect(page).toHaveURL('/crates/nanomsg');
9494
await expect(page.locator('[data-test-404-page]')).toBeVisible();
95-
await expect(page.locator('[data-test-title]')).toHaveText('nanomsg: Failed to load crate data');
95+
await expect(page.locator('[data-test-title]')).toHaveText(`'nanomsg': Failed to load crate data`);
9696
await expect(page.locator('[data-test-go-back]')).toHaveCount(0);
9797
await expect(page.locator('[data-test-try-again]')).toBeVisible();
9898
});

e2e/routes/crate/range.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ test.describe('Route | crate.range', { tag: '@routes' }, () => {
8787
await page.goto('/crates/foo/range/^3');
8888
await expect(page).toHaveURL('/crates/foo/range/%5E3');
8989
await expect(page.locator('[data-test-404-page]')).toBeVisible();
90-
await expect(page.locator('[data-test-title]')).toHaveText('foo: Failed to load crate data');
90+
await expect(page.locator('[data-test-title]')).toHaveText(`'foo': Failed to load crate data`);
9191
await expect(page.locator('[data-test-go-back]')).toHaveCount(0);
9292
await expect(page.locator('[data-test-try-again]')).toBeVisible();
9393
});

tests/acceptance/crate-dependencies-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ module('Acceptance | crate dependencies page', function (hooks) {
4646
await visit('/crates/foo/1.0.0/dependencies');
4747
assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies');
4848
assert.dom('[data-test-404-page]').exists();
49-
assert.dom('[data-test-title]').hasText('foo: Crate not found');
49+
assert.dom('[data-test-title]').hasText(`'foo': Crate not found`);
5050
assert.dom('[data-test-go-back]').exists();
5151
assert.dom('[data-test-try-again]').doesNotExist();
5252
});
@@ -57,7 +57,7 @@ module('Acceptance | crate dependencies page', function (hooks) {
5757
await visit('/crates/foo/1.0.0/dependencies');
5858
assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies');
5959
assert.dom('[data-test-404-page]').exists();
60-
assert.dom('[data-test-title]').hasText('foo: Failed to load crate data');
60+
assert.dom('[data-test-title]').hasText(`'foo': Failed to load crate data`);
6161
assert.dom('[data-test-go-back]').doesNotExist();
6262
assert.dom('[data-test-try-again]').exists();
6363
});

tests/acceptance/crate-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ module('Acceptance | crate page', function (hooks) {
8787
await visit('/crates/nanomsg');
8888
assert.strictEqual(currentURL(), '/crates/nanomsg');
8989
assert.dom('[data-test-404-page]').exists();
90-
assert.dom('[data-test-title]').hasText('nanomsg: Crate not found');
90+
assert.dom('[data-test-title]').hasText(`'nanomsg': Crate not found`);
9191
assert.dom('[data-test-go-back]').exists();
9292
assert.dom('[data-test-try-again]').doesNotExist();
9393
});
@@ -98,7 +98,7 @@ module('Acceptance | crate page', function (hooks) {
9898
await visit('/crates/nanomsg');
9999
assert.strictEqual(currentURL(), '/crates/nanomsg');
100100
assert.dom('[data-test-404-page]').exists();
101-
assert.dom('[data-test-title]').hasText('nanomsg: Failed to load crate data');
101+
assert.dom('[data-test-title]').hasText(`'nanomsg': Failed to load crate data`);
102102
assert.dom('[data-test-go-back]').doesNotExist();
103103
assert.dom('[data-test-try-again]').exists();
104104
});

tests/routes/crate/range-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ module('Route | crate.range', function (hooks) {
8484
await visit('/crates/foo/range/^3');
8585
assert.strictEqual(currentURL(), '/crates/foo/range/%5E3');
8686
assert.dom('[data-test-404-page]').exists();
87-
assert.dom('[data-test-title]').hasText('foo: Crate not found');
87+
assert.dom('[data-test-title]').hasText(`'foo': Crate not found`);
8888
assert.dom('[data-test-go-back]').exists();
8989
assert.dom('[data-test-try-again]').doesNotExist();
9090
});
@@ -96,7 +96,7 @@ module('Route | crate.range', function (hooks) {
9696
await visit('/crates/foo/range/^3');
9797
assert.strictEqual(currentURL(), '/crates/foo/range/%5E3');
9898
assert.dom('[data-test-404-page]').exists();
99-
assert.dom('[data-test-title]').hasText('foo: Failed to load crate data');
99+
assert.dom('[data-test-title]').hasText(`'foo': Failed to load crate data`);
100100
assert.dom('[data-test-go-back]').doesNotExist();
101101
assert.dom('[data-test-try-again]').exists();
102102
});

0 commit comments

Comments
 (0)