-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add MS_NOSYMFOLLOW flag #4389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MS_NOSYMFOLLOW flag #4389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks fine but semver/linux.txt
needs to be updated. Any reason this is marked as a draft?
The template said to mark it as a draft if you weren't sure about the checklist items. I'll take a look at updating the semver, but won't have a chance to test locally for a while. Is local testing necessary for a change like this? |
It's usually good to run locally if possible but don't worry about it here, CI covers testing for this platform. Just update the semver file and squash and this should be good to go. |
MS_NOSYMFOLLOW (since Linux 5.10) disallows automatic following of symlinks. See: torvalds/linux@dab741e
9239e8d
to
0bc957d
Compare
Looks like the freebsd failures are present on other recent PRs. I've updated linux.txt and run the tests locally (they pass). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
MS_NOSYMFOLLOW (since Linux 5.10) disallows automatic following of symlinks. See: torvalds/linux@dab741e (backport <rust-lang#4389>) (cherry picked from commit 558f13c)
MS_NOSYMFOLLOW (since Linux 5.10) disallows automatic following of symlinks. See: torvalds/linux@dab741e (backport <rust-lang#4389>) (cherry picked from commit 558f13c)
MS_NOSYMFOLLOW (since Linux 5.10) disallows automatic following of symlinks. See: torvalds/linux@dab741e (backport <rust-lang#4389>) (cherry picked from commit 558f13c)
MS_NOSYMFOLLOW (since Linux 5.10) disallows automatic following of symlinks. See: torvalds/linux@dab741e (backport <rust-lang#4389>) (cherry picked from commit 558f13c)
MS_NOSYMFOLLOW (since Linux 5.10) disallows automatic following of symlinks. See: torvalds/linux@dab741e (backport <#4389>) (cherry picked from commit 558f13c)
Description
Adds the
MS_NOSYMFOLLOW
flag from linux/mount.hMS_NOSYMFOLLOW (since Linux 5.10) disallows automatic following of symlinks.
Sources
https://github.com/torvalds/linux/blob/ab59a8605604f71bbbc16077270dc3f39648b7fc/include/uapi/linux/mount.h
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI