Add LINK_STATE_* definitions to NetBSD and OpenBSD. #4751
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in OpenBSD module cc @semarie |
semarie
approved these changes
Oct 21, 2025
tgross35
requested changes
Oct 22, 2025
There was a problem hiding this comment.
Could you turn the doc comments into regular comments to match the others? Usually we don't add user-facing docs in this crate, instead preferring if the user refers to the manpages.
Also the comments should be permalinks, otherwise they'll wind up getting out of date. On the GH UI you can do this by clicking the triple dots in the top right then "copy permalink".
tgross35
added
stable-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing interface LINK_STATE_* definitions from sys/net/if.h
Sources
https://github.com/NetBSD/src/blob/54613ac4db31045d0ca58a7e2da7af005c6b5cd2/sys/net/if.h#L207
https://github.com/openbsd/src/blob/bac4ed8757bbe68d4cac117487958588ae27e7c2/sys/net/if.h#L135
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI