Skip to content

Commit 4d54aab

Browse files
committed
use todo if the config says so
1 parent c9896f0 commit 4d54aab

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

crates/ide-diagnostics/src/handlers/unresolved_method.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
use hir::HasSource;
22
use hir::{FileRange, HirDisplay, InFile, db::ExpandDatabase};
3+
use ide_db::assists::ExprFillDefaultMode;
34
use ide_db::text_edit::TextEdit;
45
use ide_db::{
56
assists::{Assist, AssistId},
@@ -94,7 +95,11 @@ fn add_method_fix(ctx: &DiagnosticsContext<'_>, d: &hir::UnresolvedMethodCall) -
9495
};
9596
let end_of_last_item = source.node_file_range().file_range()?.range.end();
9697

97-
let text_to_insert = format!("\n fn {}(&self) {{}}", d.name.as_str());
98+
let method_body = match ctx.config.expr_fill_default {
99+
ExprFillDefaultMode::Default | ExprFillDefaultMode::Todo => "todo!()",
100+
ExprFillDefaultMode::Underscore => "_",
101+
};
102+
let text_to_insert = format!("\n fn {}(&self) {{ {method_body} }}", d.name.as_str());
98103
Some(fix(
99104
"add-missing-method",
100105
"Add missing method",
@@ -344,7 +349,7 @@ struct Tiger;
344349
345350
impl Tiger {
346351
fn sleep(&self) {}
347-
fn roar(&self) {}
352+
fn roar(&self) { todo!() }
348353
}
349354
350355
fn main() {

0 commit comments

Comments
 (0)