-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Closed
Copy link
Labels
A-documentationArea: Adding or improving documentationArea: Adding or improving documentationA-uiArea: Clippy interface, usage and configurationArea: Clippy interface, usage and configurationC-bugCategory: Clippy is not doing the correct thingCategory: Clippy is not doing the correct thing
Description
Summary
While reviewing #10283, we stumbled across this bug that added or
as a new lint to the "Affected Lints" list.
This happened because there was an "[...], or [...]" in the configuration option documentation.
Reproducer
I tried this code:
/// Lint: PUB_UNDERSCORE_FIELDS
///
/// Lint "public" fields in a struct that are prefixed with an underscore based on their
/// exported visibility, or whether they are marked as "pub".
(pub_underscore_fields_behavior: PubUnderscoreFieldsBehaviour = PubUnderscoreFieldsBehaviour::PublicallyExported),
I expected to see this happen (in the config's documentation):
Affected lints:
Instead, this happened:
Affected lints:
This was fixed by changing that comma to a semi-colon
Version
[...]
Additional Labels
No response
Metadata
Metadata
Assignees
Labels
A-documentationArea: Adding or improving documentationArea: Adding or improving documentationA-uiArea: Clippy interface, usage and configurationArea: Clippy interface, usage and configurationC-bugCategory: Clippy is not doing the correct thingCategory: Clippy is not doing the correct thing