Skip to content

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jul 15, 2025

Needed to split the lint crate.

Both the method and loop versions of the lint should also behave the same now.

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

☔ The latest upstream changes (possibly 228f064) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unifying the code paths for the two versions is a nice improvement 👍

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants