From edd47a994a44e414fad079c7465065de3a4d9bdb Mon Sep 17 00:00:00 2001 From: Urgau Date: Thu, 17 Jul 2025 20:27:40 +0200 Subject: [PATCH 1/2] Rework triagebot custom messages when assigning a reviewer section --- src/triagebot/pr-assignment.md | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/triagebot/pr-assignment.md b/src/triagebot/pr-assignment.md index 9ce63305..309bf72a 100644 --- a/src/triagebot/pr-assignment.md +++ b/src/triagebot/pr-assignment.md @@ -125,17 +125,21 @@ title = "[beta" # title contains "[beta" in it branch = "beta" ``` -#### Custom welcome messages +#### Custom messages -Some repositories may want to use custom welcome messages instead of the preconfigured ones. It is possible to customize the welcome message shown when an "auto reviewer" is found by triagebot and the one shown when no reviewer is found. If provided, the `contributing_url` will still be used. +Some repositories may want to use custom messages instead of the preconfigured ones. It is possible to customize the message shown when auto-assigning (or not) a reviewer. If provided, the `contributing_url` will still be used. ```toml -[assign.custom_welcome_messages] -welcome-message = "Welcome message, assigning {assignee}!" -welcome-message-no-reviewer = "Welcome message for when no auto-reviewer could be selected!" +[assign.custom_messages] +auto-assign-someone = "Thanks for the contribution, assigning {assignee}!" # only required if auto-assign (`[assign.owners]` is configured +auto-assign-no-one = """ +Thanks for the contribution! + +Unfortunatly no reviewer could be found. +""" ``` -If `[assign.custom_welcome_messages]` is present, both custom messages must be provided. +The messages content are given as-is to GitHub (modulo `{assignee}`), the content can therefor use whatever GitHub supports. ## Implementation From 3738d10bc45b78b9da4e98b018f5e5812323b4c3 Mon Sep 17 00:00:00 2001 From: Urgau <3616612+Urgau@users.noreply.github.com> Date: Thu, 17 Jul 2025 22:01:03 +0200 Subject: [PATCH 2/2] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jakub Beránek --- src/triagebot/pr-assignment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/triagebot/pr-assignment.md b/src/triagebot/pr-assignment.md index 309bf72a..5e1a447b 100644 --- a/src/triagebot/pr-assignment.md +++ b/src/triagebot/pr-assignment.md @@ -135,11 +135,11 @@ auto-assign-someone = "Thanks for the contribution, assigning {assignee}!" # onl auto-assign-no-one = """ Thanks for the contribution! -Unfortunatly no reviewer could be found. +Unfortunately, no reviewer could be found at the moment. """ ``` -The messages content are given as-is to GitHub (modulo `{assignee}`), the content can therefor use whatever GitHub supports. +The messages content are given as-is to GitHub (modulo `{assignee}`), the content can therefore use whatever GitHub supports. ## Implementation