Unrolled build for #153465

Rollup merge of #153465 - obi1kenobi:pg/trailing-bracket-fix, r=aDotInTheVoid

Fix incorrect rustdoc JSON representation of `#[doc(test(..))]` attrs.

Attributes like `#[doc(test(attr(deny(rust_2018_idioms))))]` are accidentally emitted without the final `]`.

Also, the `#[doc(test(no_crate_inject))]` attribute is mistakenly emitted as `#[doc(no_crate_inject)]` — note the missing `test` wrapper.

This PR adds the missing `]` and fixes the `no_crate_inject`, and adds regression tests for both.

Thanks to the folks working on `tonic` and `pyo3` for reporting a `cargo-semver-checks` crash on Rust 1.94 in their projects, which led me to finding this bug. Refs:
- https://github.com/hyperium/tonic/actions/runs/22732044107/job/65957306230?pr=2536
- https://github.com/PyO3/pyo3/actions/runs/22745106403/job/65967167797
- obi1kenobi/cargo-semver-checks#1590

r? @aDotInTheVoid

Author: rust-timer

src/librustdoc/json/conversions.rs

@@ -1041,10 +1041,10 @@ fn maybe_from_hir_attr(attr: &hir::Attribute, item_id: ItemId, tcx: TyCtxt<'_>)
             for attr_span in test_attrs {
                 // FIXME: This is ugly, remove when `test_attrs` has been ported to new attribute API.
                 if let Ok(snippet) = source_map.span_to_snippet(*attr_span) {
-                    ret.push(Attribute::Other(format!("#[doc(test(attr({snippet})))")));
+                    ret.push(Attribute::Other(format!("#[doc(test(attr({snippet})))]")));
                 }
             }
-            toggle_attr(&mut ret, "no_crate_inject", no_crate_inject);
+            toggle_attr(&mut ret, "test(no_crate_inject)", no_crate_inject);
             return ret;
         }
 

tests/rustdoc-json/attrs/no_crate_inject.rs

@@ -0,0 +1,7 @@
+// Regression test for rustdoc JSON emitting
+// `#[doc(no_crate_inject)]` instead of `#[doc(test(no_crate_inject))]`:
+// https://github.com/rust-lang/rust/pull/153465
+
+//@ is "$.index[?(@.inner.module.is_crate)].attrs" '[{"other": "#[doc(test(no_crate_inject))]"}]'
+
+#![doc(test(no_crate_inject))]

tests/rustdoc-json/attrs/trailing_bracket.rs

@@ -0,0 +1,7 @@
+// Regression test for rustdoc JSON emitting
+// `#[doc(test(attr(deny(rust_2018_idioms))))` without the trailing `]`:
+// https://github.com/rust-lang/rust/pull/153465
+
+//@ is "$.index[?(@.inner.module.is_crate)].attrs" '[{"other": "#[doc(test(attr(deny(rust_2018_idioms))))]"}]'
+
+#![doc(test(attr(deny(rust_2018_idioms))))]