Fix -Ctarget-features getting ignored after crt-static
#144143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behaviour introduced by commit a50a3b8 would discard any target features specified after crt-static (the only member of RUSTC_SPECIFIC_FEATURES). This is because it returned instead of continuing processing the next flag. Signed-off-by: Jens Reidel <[email protected]>
Signed-off-by: Jens Reidel <[email protected]>
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_ssa |
rustbot
added
the
T-compiler
Gelbpunkt
changed the title
-Ctarget-features getting ignored after crt-static-Ctarget-features getting ignored after crt-static
|
This should probably also be backported to 1.89. |
workingjubilee
added
the
beta-nominated
|
Regression introduced in #140920 |
|
Zulip discussion: #t-compiler/help > Lots of ABI/target-feature test fails |
|
@Gelbpunkt can you open an issue for this? We usually don't require issues for bug fixes but we use them for tracking backports, so it would be useful here. |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour introduced by commit a50a3b8 would discard any target features specified after
crt-static(the only member ofRUSTC_SPECIFIC_FEATURES). This is because it returned instead of continuing processing the next feature.I wasn't entirely sure how the regression test should look like, but this one should do. If anyone has some suggestions, I'm happy to learn, it's my first test :)
I've confirmed that the test fails without the fix on
powerpc64le-unknown-linux-muslandx86_64-unknown-linux-gnu.cc @RalfJung