Rollup of 5 pull requests #144181

jieyouxu · 2025-07-19T15:44:16Z

Successful merges:

Tidy cleanup 2 #143960 (Tidy cleanup 2)
docs: update link to RISC-V and Xtensa installation guide #144149 (docs: update link to RISC-V and Xtensa installation guide)
Rename optional-mingw-check-1 to optional-pr-check-1 #144152 (Rename optional-mingw-check-1 to optional-pr-check-1)
Fix clippy lints in librustdoc #144178 (Fix clippy lints in librustdoc)
fix load-bearing typo #144180 (fix load-bearing typo)

r? @ghost
@rustbot modify labels: rollup

…acrum Tidy cleanup 2

docs: update link to RISC-V and Xtensa installation guide Replace outdated link https://docs.esp-rs.org/book/installation/riscv-and-xtensa.html with the official Espressif documentation at https://docs.espressif.com/projects/rust/book/installation/index.html

Rename `optional-mingw-check-1` to `optional-pr-check-1` I noticed this when doing a `bors2 try` for `mingw`. I also changed it to use the `pr-check-1` image as `mingw-check-1` no longer exists.

…=fmease Fix clippy lints in librustdoc

fix load-bearing typo Trying to see if this is enough to fix PR CI. How did it land without issues is a question for later. <sub>I can see the headlines already, "billion dollar infrastructure brought down by load-bearing typo".</sub>

jieyouxu · 2025-07-19T15:45:16Z

Tiny rollup to include #144180 to unbrick PR CI. See #t-infra > Spellcheck workflow now fails on all PRs (tree bad?).

@bors r+ rollup=never p=10 (PR CI spellcheck failure)

bors · 2025-07-19T15:45:19Z

📌 Commit a8daf4c has been approved by jieyouxu

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #143960 (Tidy cleanup 2) - #144149 (docs: update link to RISC-V and Xtensa installation guide) - #144152 (Rename `optional-mingw-check-1` to `optional-pr-check-1`) - #144178 (Fix clippy lints in librustdoc) - #144180 (fix load-bearing typo) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-07-19T17:15:45Z

⌛ Testing commit a8daf4c with merge 1d30b9d...

lqd · 2025-07-19T18:17:13Z

there's a p-critical fix in the queue at p=6, we shouldn't make rollups at p>5 without rolling up the other important PRs

jieyouxu · 2025-07-19T18:19:30Z

Given that this is still quite early, we can yield to to the P-critical. Also I thought the spellcheck was blocking, but it wasn't so...

@bors p=5
@bors retry (yielding to P-critical fix)

lqd · 2025-07-19T18:22:50Z

There likely was still time to get both in, but why not :)

lqd · 2025-07-19T18:24:23Z

but yeah it'd be cutting it close, it may even be close now, with CI now taking 3+ hours; good call

bors · 2025-07-19T21:38:26Z

⌛ Testing commit a8daf4c with merge ee3a078...

bors · 2025-07-20T00:38:06Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing ee3a078 to master...

rust-timer · 2025-07-20T00:39:32Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#143960	Tidy cleanup 2	`445be5bcb3a2273338b747363b11be1f6f88ff5b` (link)
#144149	docs: update link to RISC-V and Xtensa installation guide	`6af98966419fe460076d40f9bba62461871fe235` (link)
#144152	Rename `optional-mingw-check-1` to `optional-pr-check-1`	`a176e5c77841bc3d41bec4f5a6cabc7737b11e1c` (link)
#144178	Fix clippy lints in librustdoc	`1e20e38b124f2a1eab959455a91d8a4e9602a63e` (link)
#144180	fix load-bearing typo	`a8a4c40acc4bcb73ce9f362f9e76704bd48c556d` (link)

previous master: 0d95920262

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-07-20T00:41:06Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0d95920 (parent) -> ee3a078 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ee3a0783df39cb11c5706e38805eb9258b4fad79 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 4746.0s -> 3681.7s (-22.4%)
x86_64-apple-1: 10393.0s -> 8162.5s (-21.5%)
dist-x86_64-apple: 11155.4s -> 9178.8s (-17.7%)
dist-apple-various: 7083.9s -> 6246.5s (-11.8%)
aarch64-gnu: 6740.1s -> 6231.6s (-7.5%)
dist-s390x-linux: 4814.4s -> 5139.3s (6.7%)
dist-i586-gnu-i586-i686-musl: 5437.0s -> 5707.0s (5.0%)
aarch64-msvc-2: 5482.1s -> 5241.2s (-4.4%)
x86_64-msvc-ext2: 5558.8s -> 5351.1s (-3.7%)
dist-powerpc-linux: 4798.8s -> 4968.4s (3.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-20T01:49:19Z

Finished benchmarking commit (ee3a078): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.3%, -0.1%]	3
Improvements ✅ (secondary)	-0.5%	[-0.9%, -0.2%]	7
All ❌✅ (primary)	-0.2%	[-0.3%, -0.1%]	3

Max RSS (memory usage)

Results (primary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-3.5%, -2.1%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.7%	[-3.5%, -2.1%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.968s -> 464.521s (-0.31%)
Artifact size: 374.57 MiB -> 374.65 MiB (0.02%)

Rollup of 5 pull requests Successful merges: - rust-lang#143960 (Tidy cleanup 2) - rust-lang#144149 (docs: update link to RISC-V and Xtensa installation guide) - rust-lang#144152 (Rename `optional-mingw-check-1` to `optional-pr-check-1`) - rust-lang#144178 (Fix clippy lints in librustdoc) - rust-lang#144180 (fix load-bearing typo) r? `@ghost` `@rustbot` modify labels: rollup

hkBst and others added 12 commits July 15, 2025 08:44

tidy: more clippy fixes

0d6dc2f

tidy static regex: OnceLock -> LazyLock

da6d7ca

tidy: improve comment

32391f7

docs: update link to RISC-V and Xtensa installation guide

fb1a205

Rename optional-mingw-check to optional-pr-check

58a05ca

Fix clippy lints in librustdoc

c75edc9

fix load-bearing typo

4ef92be

Rollup merge of rust-lang#143960 - hkBst:tidy-cleanup-2, r=Mark-Simul…

c021ea8

…acrum Tidy cleanup 2

Rollup merge of rust-lang#144152 - ChrisDenton:optional-job, r=Kobzol

d0b677d

Rename `optional-mingw-check-1` to `optional-pr-check-1` I noticed this when doing a `bors2 try` for `mingw`. I also changed it to use the `pr-check-1` image as `mingw-check-1` no longer exists.

Rollup merge of rust-lang#144178 - GuillaumeGomez:fix-clippy-lints, r…

a6b625c

…=fmease Fix clippy lints in librustdoc

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2025

bors merged commit ee3a078 into rust-lang:master Jul 20, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 20, 2025

This was referenced Jul 20, 2025

rustdoc: add doc_link_canonical feature #143158

Open

Verify llvm-needs-components are not empty and match the --target value #144042

Merged

bors mentioned this pull request Jul 20, 2025

Remove tidy checks for tests/ui/issues/ #144173

Merged

jieyouxu deleted the rollup-61j2sar branch July 20, 2025 04:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #144181

Rollup of 5 pull requests #144181

Uh oh!

jieyouxu commented Jul 19, 2025 •

edited by rustbot

Loading

Uh oh!

jieyouxu commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

lqd commented Jul 19, 2025 •

edited

Loading

Uh oh!

jieyouxu commented Jul 19, 2025

Uh oh!

lqd commented Jul 19, 2025

Uh oh!

lqd commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 20, 2025

Uh oh!

github-actions bot commented Jul 20, 2025

Uh oh!

rust-timer commented Jul 20, 2025

Uh oh!

Uh oh!

Rollup of 5 pull requests #144181

Rollup of 5 pull requests #144181

Uh oh!

Conversation

jieyouxu commented Jul 19, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

lqd commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Jul 19, 2025

Uh oh!

lqd commented Jul 19, 2025

Uh oh!

lqd commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 20, 2025

Uh oh!

github-actions bot commented Jul 20, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 20, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

jieyouxu commented Jul 19, 2025 •

edited by rustbot

Loading

lqd commented Jul 19, 2025 •

edited

Loading