Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

r? @ghost

@Mark-Simulacrum
Copy link
Member Author

This reverts #66004 to get us to a point where we observed the regressions and applies #65974 to hopefully mitigate a known source of regressions. It also sets the release channel to beta.

This first try build will be the 'end' commit in our crater run, i.e., with the pre-expansion gating applied. We'll also get the start commit momentarily by building off of master with the beta commit being the only commit applied...

@bors try

@bors
Copy link
Collaborator

bors commented Nov 3, 2019

⌛ Trying commit c0a8ffe622f75d9e2e124bd47797553c410ccaad with merge 8810c24b0958114d8dbb32d878444e8956fce80f...

@Mark-Simulacrum Mark-Simulacrum force-pushed the crater-pre-expansion-gate branch from c0a8ffe to 61fec2f Compare November 3, 2019 18:09
@Mark-Simulacrum
Copy link
Member Author

@bors try

And the start commit, hopefully...

@bors
Copy link
Collaborator

bors commented Nov 3, 2019

⌛ Trying commit 61fec2f with merge 5e63397...

bors added a commit that referenced this pull request Nov 3, 2019
…try>

[no merge] crater pre-expansion gating

r? @ghost
@bors
Copy link
Collaborator

bors commented Nov 3, 2019

☀️ Try build successful - checks-azure
Build commit: 5e63397 (5e633973aa9255a88b65a39484627bb54e6044b3)

@Mark-Simulacrum
Copy link
Member Author

@craterbot run mode=check-only start=try#5e633973aa9255a88b65a39484627bb54e6044b3 end=try#8810c24b0958114d8dbb32d878444e8956fce80f cap-lints=allow

@craterbot
Copy link
Collaborator

👌 Experiment pr-66063 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 3, 2019
@craterbot
Copy link
Collaborator

🚧 Experiment pr-66063 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-66063 is completed!
📊 9 regressed and 0 fixed (77633 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 6, 2019
@Mark-Simulacrum
Copy link
Member Author

Closing this PR as we've gathered what we wanted to here, I believe. Initial assessment looks quite good (surprisingly to me, to be honest - either this was not a successful test, or no one is using unstable syntax in the wild?). I suppose we don't have that many features that touch syntax.

In any case, I'll try and followup on the original issue soon with these results.

@Mark-Simulacrum Mark-Simulacrum deleted the crater-pre-expansion-gate branch November 6, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants