Check stability and feature attributes in rustdoc #82598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jyn514
reviewed
Feb 27, 2021
GuillaumeGomez
force-pushed
the
rustdoc-rustc-pass
branch
from
f8b0113 to
3127a8d
Compare
|
Updated! |
This comment has been minimized.
This comment has been minimized.
jyn514
reviewed
Feb 27, 2021
GuillaumeGomez
force-pushed
the
rustdoc-rustc-pass
branch
from
3127a8d to
b6ebdfa
Compare
This comment has been minimized.
This comment has been minimized.
jyn514
reviewed
Feb 27, 2021
GuillaumeGomez
force-pushed
the
rustdoc-rustc-pass
branch
from
b6ebdfa to
7a967c9
Compare
|
As for the libstd feature, I could only reproduce it locally after updating to last commit so I guess it's a very recent change and it was an incomplete one. Lucky us that we found out this early. |
|
Heh, I thought the lack of a stability attribute might be an issue! #82420 (comment) |
jyn514
reviewed
Feb 28, 2021
jyn514
changed the title
GuillaumeGomez
force-pushed
the
rustdoc-rustc-pass
branch
from
7a967c9 to
e2c175e
Compare
|
Update the version to 1.35 in both attributes. |
|
Thanks. Can you also update https://github.com/rust-lang/rust/blob/e2c175ecdf0207bd34192c292dabd816659b370c/library/std/src/sys/mod.rs#L114 while you're at it? |
GuillaumeGomez
force-pushed
the
rustdoc-rustc-pass
branch
from
e2c175e to
95dbf0c
Compare
|
Done as well! |
|
r=me with CI passing, thanks for fixing this! |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
rustdoc-rustc-pass
branch
from
95dbf0c to
8548c47
Compare
jyn514
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
rustdoc-rustc-pass
branch
from
8548c47 to
d20fd62
Compare
|
@bors: r=jyn514 |
|
📌 Commit d20fd62 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 2, 2021
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#80734 (check that first arg to `panic!()` in const is `&str`) - rust-lang#81932 (Always compile rustdoc with debug logging enabled when `download-rustc` is set) - rust-lang#82018 (Remove the dummy cache in `DocContext`; delete RenderInfo) - rust-lang#82598 (Check stability and feature attributes in rustdoc) - rust-lang#82655 (Highlight identifier span instead of whole pattern span in `unused` lint) - rust-lang#82662 (Warn about unknown doc attributes) - rust-lang#82676 (Change twice used large const table to static) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82588.
cc @Nemo157 @camelid
r? @jyn514