Skip to content

Add explanatory note to bare_urls lint #83762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2021
Merged

Add explanatory note to bare_urls lint #83762

merged 1 commit into from
Apr 14, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Apr 1, 2021 •
edited
Loading

I think the lint is confusing otherwise since it doesn't fully explain
what the problem is.

@camelid camelid added A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 1, 2021
@rust-highfive
Copy link
Contributor

r? @CraftSpider

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camelid
Copy link
Member Author

camelid commented Apr 1, 2021

Spurious CI failure, retrying jobs.

@camelid
Copy link
Member Author

camelid commented Apr 1, 2021

(Note that the lint is not called bare_urls yet, but will be soon: #81764)

@jyn514
Copy link
Member

jyn514 commented Apr 2, 2021

I don't think this change makes sense to land before #81764. This error makes no sense:

error: unneeded long form for URL
  --> $DIR/url-improvements.rs:5:5
   |
LL | /// [http://bb.com]
   |     ^^^^^^^^^^^^^^^ help: use an automatic link instead: `<http://bb.com>`
   |
   = note: bare URLs are not automatically turned into clickable links

@camelid
Copy link
Member Author

camelid commented Apr 2, 2021

Ah, good point. I'll mark this is as blocked on that PR.

@camelid
Copy link
Member Author

camelid commented Apr 2, 2021

r? @jyn514

@rustbot label: +S-blocked -S-waiting-on-review

@rust-highfive rust-highfive assigned jyn514 and unassigned CraftSpider Apr 2, 2021
@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2021
@bors

This comment has been minimized.

Sign in to view
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Apr 8, 2021
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2021
@camelid
Add explanatory note to bare_urls lint
dbbbdf1 
I think the lint is confusing otherwise since it doesn't fully explain
what the problem is.
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2021
@jyn514
Copy link
Member

jyn514 commented Apr 13, 2021

r=me with CI passing

@camelid
Copy link
Member Author

camelid commented Apr 14, 2021

@bors r=jyn514 rollup

@bors
Copy link
Collaborator

bors commented Apr 14, 2021

📌 Commit dbbbdf1 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2021
@bors
Copy link
Collaborator

bors commented Apr 14, 2021

⌛ Testing commit dbbbdf1 with merge d408fdd...

@bors
Copy link
Collaborator

bors commented Apr 14, 2021

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing d408fdd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 14, 2021
@bors bors merged commit d408fdd into rust-lang:master Apr 14, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 14, 2021
@camelid camelid deleted the bare-urls-note branch April 15, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Thaddeus5555555 Thaddeus5555555 Thaddeus5555555 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jyn514 jyn514

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
8 participants
@camelid @rust-highfive @rust-log-analyzer @jyn514 @bors @Thaddeus5555555 @CraftSpider @rustbot