Skip to content

Commit ee0b821

Browse files
authored
Merge pull request #2188 from Kobzol/dont-panic-s3
Do not panic on S3 file upload failures
2 parents 1c64fa0 + 67a2940 commit ee0b821

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

collector/src/compile/execute/bencher.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -338,9 +338,9 @@ impl SelfProfileS3Upload {
338338
let start = std::time::Instant::now();
339339
let status = self.0.wait().expect("waiting for child");
340340
if !status.success() {
341-
panic!("S3 upload failed: {:?}", status);
341+
log::error!("S3 upload failed: {status:?}");
342+
} else {
343+
log::trace!("uploaded to S3, additional wait: {:?}", start.elapsed());
342344
}
343-
344-
log::trace!("uploaded to S3, additional wait: {:?}", start.elapsed());
345345
}
346346
}

0 commit comments

Comments
 (0)