Skip to content

Commit f83a503

Browse files
lqdlqd
authored
Merge pull request #2242 from Mark-Simulacrum/triage
Add triage for this week
2 parents 9184578 + 71a1366 commit f83a503

File tree

1 file changed

+136
-0
lines changed

1 file changed

+136
-0
lines changed

‎triage/2025/2025-09-07.md

Lines changed: 136 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,136 @@
1+
# 2025-09-07 Triage Log
2+
3+
Overall, a fairly neutral week with relatively few changes affecting
4+
performance landing.
5+
6+
Triage done by **@simulacrum**.
7+
Revision range: [75ee9ffd..f13ef0d7](https://perf.rust-lang.org/?start=75ee9ffd5ed3649c0a09493057adaa8feebb2035&end=f13ef0d75d834c826c9479a5d244bcfb9891df45&absolute=false&stat=instructions%3Au)
8+
9+
**Summary**:
10+
11+
| (instructions:u) | mean | range | count |
12+
|:----------------------------------:|:-----:|:--------------:|:-----:|
13+
| Regressions ❌ <br /> (primary) | 0.5% | [0.1%, 1.6%] | 54 |
14+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.0%, 0.5%] | 54 |
15+
| Improvements ✅ <br /> (primary) | -0.7% | [-5.6%, -0.1%] | 18 |
16+
| Improvements ✅ <br /> (secondary) | -1.5% | [-5.7%, -0.0%] | 43 |
17+
| All ❌✅ (primary) | 0.2% | [-5.6%, 1.6%] | 72 |
18+
19+
1 Regression, 5 Improvements, 3 Mixed; 4 of them in rollups
20+
33 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 5 pull requests [#146224](https://github.com/rust-lang/rust/pull/146224) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ad85bc524b1ad696e42061ad8338d382dffbdbe5&end=c559c4a741836c4ffa8e4f60cb9fe7e92af5298e&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 2 |
29+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.0%, 0.3%] | 8 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.1% | [0.1%, 0.1%] | 2 |
33+
34+
Doc-only effects, likely from changes to std/core. Not worth digging deeper.
35+
36+
#### Improvements
37+
38+
cleanup and cache proof tree building [#145951](https://github.com/rust-lang/rust/pull/145951) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f6df223ea8c0017e64ce19c99afa32c0c629142c&end=a2c8b0b92c14b02f0b3f96a0d5296f1090dc286b&stat=instructions:u)
39+
40+
| (instructions:u) | mean | range | count |
41+
|:----------------------------------:|:-----:|:--------------:|:-----:|
42+
| Regressions ❌ <br /> (primary) | - | - | 0 |
43+
| Regressions ❌ <br /> (secondary) | 0.0% | [0.0%, 0.0%] | 1 |
44+
| Improvements ✅ <br /> (primary) | - | - | 0 |
45+
| Improvements ✅ <br /> (secondary) | -3.0% | [-5.7%, -0.1%] | 15 |
46+
| All ❌✅ (primary) | - | - | 0 |
47+
48+
49+
rustdoc-search: yet another stringdex optimization attempt [#145911](https://github.com/rust-lang/rust/pull/145911) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0d6a806909f8e99ad59d3ca96dee012faf9a38e9&end=af00ff2ce62b6617ed19305ae39e135ac71d0b22&stat=instructions:u)
50+
51+
| (instructions:u) | mean | range | count |
52+
|:----------------------------------:|:-----:|:--------------:|:-----:|
53+
| Regressions ❌ <br /> (primary) | - | - | 0 |
54+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
55+
| Improvements ✅ <br /> (primary) | -0.8% | [-6.0%, -0.1%] | 11 |
56+
| Improvements ✅ <br /> (secondary) | -1.0% | [-2.4%, -0.2%] | 3 |
57+
| All ❌✅ (primary) | -0.8% | [-6.0%, -0.1%] | 11 |
58+
59+
60+
resolve: Avoid finalizing extern prelude entries more than once [#144737](https://github.com/rust-lang/rust/pull/144737) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=91edc3ebccc4daa46c20a93f4709862376da1fdd&end=ad85bc524b1ad696e42061ad8338d382dffbdbe5&stat=instructions:u)
61+
62+
| (instructions:u) | mean | range | count |
63+
|:----------------------------------:|:-----:|:--------------:|:-----:|
64+
| Regressions ❌ <br /> (primary) | - | - | 0 |
65+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
66+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.1%, -0.1%] | 6 |
67+
| Improvements ✅ <br /> (secondary) | -1.1% | [-2.0%, -0.4%] | 8 |
68+
| All ❌✅ (primary) | -0.1% | [-0.1%, -0.1%] | 6 |
69+
70+
71+
Rollup of 5 pull requests [#146267](https://github.com/rust-lang/rust/pull/146267) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0d0f4eac8b98133e5da6d3604d86a8f3b5a67844&end=6d5caf3a4a358c80f09ba51d71db0dbc41381992&stat=instructions:u)
72+
73+
| (instructions:u) | mean | range | count |
74+
|:----------------------------------:|:-----:|:--------------:|:-----:|
75+
| Regressions ❌ <br /> (primary) | - | - | 0 |
76+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
77+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.2%, -0.1%] | 2 |
78+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.7%, -0.1%] | 15 |
79+
| All ❌✅ (primary) | -0.1% | [-0.2%, -0.1%] | 2 |
80+
81+
82+
Make the allocator shim participate in LTO again [#146232](https://github.com/rust-lang/rust/pull/146232) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6d5caf3a4a358c80f09ba51d71db0dbc41381992&end=bea625f3275e3c897dc965ed97a1d19ef7831f01&stat=instructions:u)
83+
84+
| (instructions:u) | mean | range | count |
85+
|:----------------------------------:|:-----:|:--------------:|:-----:|
86+
| Regressions ❌ <br /> (primary) | - | - | 0 |
87+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.2%] | 2 |
88+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.9%, -0.3%] | 221 |
89+
| Improvements ✅ <br /> (secondary) | -0.9% | [-2.2%, -0.0%] | 260 |
90+
| All ❌✅ (primary) | -0.9% | [-1.9%, -0.3%] | 221 |
91+
92+
93+
#### Mixed
94+
95+
Rollup of 24 pull requests [#146185](https://github.com/rust-lang/rust/pull/146185) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9385c64c95d971329e62917adc4349c8ccdbafe0&end=033c0a4742794f5608b19eb78458726596f8ec18&stat=instructions:u)
96+
97+
| (instructions:u) | mean | range | count |
98+
|:----------------------------------:|:-----:|:--------------:|:-----:|
99+
| Regressions ❌ <br /> (primary) | 0.6% | [0.1%, 1.6%] | 39 |
100+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.0%, 0.6%] | 27 |
101+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.9%, -0.2%] | 12 |
102+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.5%, -0.1%] | 9 |
103+
| All ❌✅ (primary) | 0.3% | [-0.9%, 1.6%] | 51 |
104+
105+
Regressions mostly from:
106+
107+
- [On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const](https://github.com/rust-lang/rust/pull/145827)
108+
- [Allow inline(always) with a target feature behind a unstable feature `target_feature_inline_always`.](https://github.com/rust-lang/rust/pull/145932)
109+
110+
Doesn't seem worth digging deeper - these are features or diagnostic
111+
improvements and the regressions aren't too large or two widespread.
112+
113+
Rollup of 5 pull requests [#146192](https://github.com/rust-lang/rust/pull/146192) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=79bdc627562db90599edcf16cb166a532919a0a8&end=45b9d13b455f820c12760e0fbf6ce69110a3aeda&stat=instructions:u)
114+
115+
| (instructions:u) | mean | range | count |
116+
|:----------------------------------:|:-----:|:--------------:|:-----:|
117+
| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 1 |
118+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.4%] | 2 |
119+
| Improvements ✅ <br /> (primary) | - | - | 0 |
120+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.5%, -0.1%] | 7 |
121+
| All ❌✅ (primary) | 0.1% | [0.1%, 0.1%] | 1 |
122+
123+
Regressions largely recovered in subsequent commits (though not in related PRs,
124+
so possibly spurious in the first place) and don't seem worth further followup.
125+
126+
Rework how the codegen coordinator code handles the allocator shim [#145955](https://github.com/rust-lang/rust/pull/145955) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=45b9d13b455f820c12760e0fbf6ce69110a3aeda&end=71289c378d0a406a4f537fe4001282d19362931f&stat=instructions:u)
127+
128+
| (instructions:u) | mean | range | count |
129+
|:----------------------------------:|:-----:|:--------------:|:-----:|
130+
| Regressions ❌ <br /> (primary) | 0.9% | [0.3%, 2.0%] | 229 |
131+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.0%, 2.2%] | 259 |
132+
| Improvements ✅ <br /> (primary) | - | - | 0 |
133+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.0%] | 4 |
134+
| All ❌✅ (primary) | 0.9% | [0.3%, 2.0%] | 229 |
135+
136+
The regressions here are clawed back in [Make the allocator shim participate in LTO again](https://github.com/rust-lang/rust/pull/146232).

0 commit comments

Comments
 (0)