Skip to content

Commit a18f53a

Browse files
committed
Comment some tests in the m68k CI because we cannot run programs on architectures not supported by the object crate anymore
1 parent ecd958f commit a18f53a

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

.github/workflows/m68k.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,11 @@ jobs:
9191
./y.sh prepare --only-libcore --cross
9292
./y.sh build --sysroot --features compiler-builtins-no-f16-f128 --target-triple m68k-unknown-linux-gnu
9393
./y.sh test --mini-tests --target-triple m68k-unknown-linux-gnu
94-
CG_GCC_TEST_TARGET=m68k-unknown-linux-gnu ./y.sh test --cargo-tests --target-triple m68k-unknown-linux-gnu
94+
# FIXME: since https://github.com/rust-lang/rust/pull/140809, we cannot run programs for architectures not
95+
# supported by the object crate, since this adds a dependency on symbols.o for the panic runtime.
96+
# And as such, a wrong order of the object files in the linker command now fails with an undefined reference
97+
# to some symbols like __rustc::rust_panic.
98+
#CG_GCC_TEST_TARGET=m68k-unknown-linux-gnu ./y.sh test --cargo-tests --target-triple m68k-unknown-linux-gnu
9599
./y.sh clean all
96100
97101
- name: Prepare dependencies
@@ -100,9 +104,10 @@ jobs:
100104
git config --global user.name "User"
101105
./y.sh prepare --cross
102106
103-
- name: Run tests
104-
run: |
105-
./y.sh test --target-triple m68k-unknown-linux-gnu --release --clean --build-sysroot --sysroot-features compiler-builtins-no-f16-f128 ${{ matrix.commands }}
107+
# FIXME: We cannot run programs for architectures not supported by the object crate. See comment above.
108+
#- name: Run tests
109+
#run: |
110+
#./y.sh test --target-triple m68k-unknown-linux-gnu --release --clean --build-sysroot --sysroot-features compiler-builtins-no-f16-f128 ${{ matrix.commands }}
106111

107112
- name: Run Hello World!
108113
run: |

0 commit comments

Comments
 (0)