fix(download_tracker): remove unnecessary attributes from the DownloadTracker struct

The attributes `display_progress` and `stdout_is_a_tty` are only needed
when defining the draw target for the progress bars. After that, they
don't need to be used anymore.

Author: FranciscoTGouveia

src/cli/download_tracker.rs

@@ -11,9 +11,6 @@ use crate::utils::Notification as Un;
 /// *not* safe for tracking concurrent downloads yet - it is basically undefined
 /// what will happen.
 pub(crate) struct DownloadTracker {
-    /// Whether we display progress or not.
-    display_progress: bool,
-    stdout_is_a_tty: bool,
     /// Whether we display colors or not.
     use_colors: bool,
     /// MultiProgress bar for the downloads.
@@ -34,12 +31,10 @@ impl DownloadTracker {
                     ProgressDrawTarget::term_like(Box::new(t))
                 }
                 Ok(s) if s.eq_ignore_ascii_case("never") => ProgressDrawTarget::hidden(),
-                _ if is_a_tty => ProgressDrawTarget::term_like(Box::new(t)),
+                _ if is_a_tty && display_progress => ProgressDrawTarget::term_like(Box::new(t)),
                 _ => ProgressDrawTarget::hidden(),
             });
         Self {
-            display_progress,
-            stdout_is_a_tty: process.stdout().is_a_tty(process),
             use_colors,
             multi_progress_bars,
             progress_bar: ProgressBar::hidden(),
@@ -53,9 +48,7 @@ impl DownloadTracker {
                 true
             }
             Notification::Install(In::Utils(Un::DownloadDataReceived(data))) => {
-                if self.stdout_is_a_tty {
-                    self.data_received(data.len());
-                }
+                self.data_received(data.len());
                 true
             }
             Notification::Install(In::Utils(Un::DownloadFinished)) => {
@@ -85,11 +78,7 @@ impl DownloadTracker {
 
     /// Notifies self that data of size `len` has been received.
     pub(crate) fn data_received(&mut self, len: usize) {
-        if self.progress_bar.is_hidden()
-            && self.display_progress
-            && self.stdout_is_a_tty
-            && self.progress_bar.elapsed() >= Duration::from_secs(1)
-        {
+        if self.progress_bar.is_hidden() && self.progress_bar.elapsed() >= Duration::from_secs(1) {
             self.multi_progress_bars.add(self.progress_bar.clone());
         }
         self.progress_bar.inc(len as u64);