Skip to content

Commit f18a188

Browse files
committed
Run cargo clippy and cargo fmt
Signed-off-by: Gris Ge <[email protected]>
1 parent 56ee8b6 commit f18a188

File tree

7 files changed

+55
-27
lines changed

7 files changed

+55
-27
lines changed

.rustfmt.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
max_width = 80
2+
wrap_comments = true
3+
reorder_imports = true
4+
edition = "2021"

examples/add_rules.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,18 @@
99
use audit::{
1010
new_connection,
1111
packet::{
12-
constants::AUDIT_ARCH_X86_64, RuleAction, RuleField, RuleFieldFlags, RuleFlags,
13-
RuleMessage, RuleSyscalls,
12+
constants::AUDIT_ARCH_X86_64, RuleAction, RuleField, RuleFieldFlags,
13+
RuleFlags, RuleMessage, RuleSyscalls,
1414
},
1515
Error, Handle,
1616
};
1717

1818
#[tokio::main]
1919
async fn main() -> Result<(), String> {
20-
let (connection, handle, _) = new_connection().map_err(|e| format!("{}", e))?;
20+
let (connection, handle, _) =
21+
new_connection().map_err(|e| format!("{e}"))?;
2122
tokio::spawn(connection);
22-
add_rules(handle).await.map_err(|e| format!("{}", e))
23+
add_rules(handle).await.map_err(|e| format!("{e}"))
2324
}
2425

2526
async fn add_rules(mut handle: Handle) -> Result<(), Error> {

examples/dump_audit_rules.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,16 @@ use futures::stream::TryStreamExt;
88

99
#[tokio::main]
1010
async fn main() -> Result<(), String> {
11-
let (connection, handle, _) = new_connection().map_err(|e| format!("{}", e))?;
11+
let (connection, handle, _) =
12+
new_connection().map_err(|e| format!("{e}"))?;
1213
tokio::spawn(connection);
13-
list_rules(handle).await.map_err(|e| format!("{}", e))
14+
list_rules(handle).await.map_err(|e| format!("{e}"))
1415
}
1516

1617
async fn list_rules(mut handle: Handle) -> Result<(), Error> {
1718
let mut rules = handle.list_rules();
1819
while let Some(rule) = rules.try_next().await? {
19-
println!("{:?}", rule);
20+
println!("{rule:?}");
2021
}
2122
Ok(())
2223
}

examples/events.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@ use futures::stream::StreamExt;
88

99
#[tokio::main]
1010
async fn main() -> Result<(), String> {
11-
let (connection, mut handle, mut messages) = new_connection().map_err(|e| format!("{}", e))?;
11+
let (connection, mut handle, mut messages) =
12+
new_connection().map_err(|e| format!("{e}"))?;
1213

1314
tokio::spawn(connection);
14-
handle.enable_events().await.map_err(|e| format!("{}", e))?;
15+
handle.enable_events().await.map_err(|e| format!("{e}"))?;
1516

1617
env_logger::init();
1718
while let Some((msg, _)) = messages.next().await {
18-
println!("{:?}", msg);
19+
println!("{msg:?}");
1920
}
2021
Ok(())
2122
}

examples/events_async.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ use futures::stream::StreamExt;
88

99
#[async_std::main]
1010
async fn main() -> Result<(), String> {
11-
let (connection, mut handle, mut messages) = new_connection().map_err(|e| format!("{}", e))?;
11+
let (connection, mut handle, mut messages) =
12+
new_connection().map_err(|e| format!("{}", e))?;
1213

1314
async_std::task::spawn(connection);
1415

src/handle.rs

Lines changed: 28 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ use futures::{
88
FutureExt,
99
};
1010
use netlink_packet_core::{
11-
NetlinkMessage, NetlinkPayload, NLM_F_ACK, NLM_F_CREATE, NLM_F_DUMP, NLM_F_EXCL, NLM_F_NONREC,
12-
NLM_F_REQUEST,
11+
NetlinkMessage, NetlinkPayload, NLM_F_ACK, NLM_F_CREATE, NLM_F_DUMP,
12+
NLM_F_EXCL, NLM_F_NONREC, NLM_F_REQUEST,
1313
};
1414
use netlink_proto::{sys::SocketAddr, ConnectionHandle};
1515

@@ -62,7 +62,10 @@ impl Handle {
6262
/// Send a netlink message that expects an acknowledgement. The returned
6363
/// future resolved when that ACK is received. If anything else is
6464
/// received, the future resolves into an error.
65-
async fn acked_request(&mut self, message: NetlinkMessage<AuditMessage>) -> Result<(), Error> {
65+
async fn acked_request(
66+
&mut self,
67+
message: NetlinkMessage<AuditMessage>,
68+
) -> Result<(), Error> {
6669
let mut response = self.request(message)?;
6770
if let Some(message) = response.next().await {
6871
let (header, payload) = message.into_parts();
@@ -83,7 +86,8 @@ impl Handle {
8386
/// Add the given rule
8487
pub async fn add_rule(&mut self, rule: RuleMessage) -> Result<(), Error> {
8588
let mut req = NetlinkMessage::from(AuditMessage::AddRule(rule));
86-
req.header.flags = NLM_F_REQUEST | NLM_F_ACK | NLM_F_EXCL | NLM_F_CREATE;
89+
req.header.flags =
90+
NLM_F_REQUEST | NLM_F_ACK | NLM_F_EXCL | NLM_F_CREATE;
8791
self.acked_request(req).await
8892
}
8993

@@ -95,24 +99,30 @@ impl Handle {
9599
}
96100

97101
/// List the current rules
98-
pub fn list_rules(&mut self) -> impl TryStream<Ok = RuleMessage, Error = Error> {
102+
pub fn list_rules(
103+
&mut self,
104+
) -> impl TryStream<Ok = RuleMessage, Error = Error> {
99105
let mut req = NetlinkMessage::from(AuditMessage::ListRules(None));
100106
req.header.flags = NLM_F_REQUEST | NLM_F_DUMP;
101107

102108
match self.request(req) {
103109
Ok(response) => Either::Left(response.map(move |msg| {
104110
let (header, payload) = msg.into_parts();
105111
match payload {
106-
NetlinkPayload::InnerMessage(AuditMessage::ListRules(Some(rule_msg))) => {
107-
Ok(rule_msg)
112+
NetlinkPayload::InnerMessage(AuditMessage::ListRules(
113+
Some(rule_msg),
114+
)) => Ok(rule_msg),
115+
NetlinkPayload::Error(err_msg) => {
116+
Err(Error::NetlinkError(err_msg))
108117
}
109-
NetlinkPayload::Error(err_msg) => Err(Error::NetlinkError(err_msg)),
110118
_ => Err(Error::UnexpectedMessage(NetlinkMessage::new(
111119
header, payload,
112120
))),
113121
}
114122
})),
115-
Err(e) => Either::Right(future::err::<RuleMessage, Error>(e).into_stream()),
123+
Err(e) => Either::Right(
124+
future::err::<RuleMessage, Error>(e).into_stream(),
125+
),
116126
}
117127
}
118128

@@ -136,10 +146,15 @@ impl Handle {
136146
let response = request.next().await.ok_or(Error::RequestFailed)?;
137147

138148
match response.into_parts() {
139-
(_, NetlinkPayload::InnerMessage(AuditMessage::GetStatus(Some(status)))) => Ok(status),
140-
(header, payload) => Err(Error::UnexpectedMessage(NetlinkMessage::new(
141-
header, payload,
142-
))),
149+
(
150+
_,
151+
NetlinkPayload::InnerMessage(AuditMessage::GetStatus(Some(
152+
status,
153+
))),
154+
) => Ok(status),
155+
(header, payload) => Err(Error::UnexpectedMessage(
156+
NetlinkMessage::new(header, payload),
157+
)),
143158
}
144159
}
145160
}

src/lib.rs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@ use futures::channel::mpsc::UnboundedReceiver;
2020
#[allow(clippy::type_complexity)]
2121
#[cfg(feature = "tokio_socket")]
2222
pub fn new_connection() -> io::Result<(
23-
proto::Connection<packet::AuditMessage, sys::TokioSocket, packet::NetlinkAuditCodec>,
23+
proto::Connection<
24+
packet::AuditMessage,
25+
sys::TokioSocket,
26+
packet::NetlinkAuditCodec,
27+
>,
2428
Handle,
2529
UnboundedReceiver<(NetlinkMessage<packet::AuditMessage>, sys::SocketAddr)>,
2630
)> {
@@ -36,7 +40,8 @@ pub fn new_connection_with_socket<S>() -> io::Result<(
3640
where
3741
S: sys::AsyncSocket,
3842
{
39-
let (conn, handle, messages) =
40-
netlink_proto::new_connection_with_codec(sys::protocols::NETLINK_AUDIT)?;
43+
let (conn, handle, messages) = netlink_proto::new_connection_with_codec(
44+
sys::protocols::NETLINK_AUDIT,
45+
)?;
4146
Ok((conn, Handle::new(handle), messages))
4247
}

0 commit comments

Comments
 (0)