Cleanup round 2

Author: daniel-noland

src/tc/filters/cls_flower.rs

@@ -1,5 +1,5 @@
-#![deny(clippy::all, clippy::pedantic)]
 // SPDX-License-Identifier: MIT
+#![deny(clippy::all, clippy::pedantic)]
 /// flower filter
 use std::net::{Ipv4Addr, Ipv6Addr};
 
@@ -499,6 +499,8 @@ impl ErspanHwid {
         Self(hwid)
     }
 
+    /// # Errors
+    /// Returns `DecodeError` if the value is greater than 63.
     pub fn new_checked(hwid: u8) -> Result<Self, DecodeError> {
         if hwid >= (1 << 6) {
             return Err(DecodeError::from(format!(
@@ -815,6 +817,7 @@ struct FlowerActionList(Vec<FlowerAction>);
 impl From<&Vec<TcAction>> for FlowerActionList {
     fn from(actions: &Vec<TcAction>) -> Self {
         Self(
+            actions
             actions
                 .iter()
                 .enumerate()
@@ -2014,20 +2017,22 @@ impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<NlaBuffer<&'a T>>
                 Self::KeyMplsLabel(parse_u32(payload)?)
             }
             TCA_FLOWER_KEY_TCP_FLAGS => {
-                if payload.len() != 2 {
-                    return Err(DecodeError::from("invalid tcp flags length"));
+                let flags = parse_u16_be(payload)?;
+                if flags > 0xff {
+                    return Err(DecodeError::from(
+                        "invalid tcp flags value",
+                    ));
                 }
-                let flags = BigEndian::read_u16(payload);
-                Self::KeyTcpFlags(TcpFlags::from_bits_retain(flags as u8))
+                Self::KeyTcpFlags(TcpFlags::from_bits_retain((flags & 0xff) as u8))
             }
             TCA_FLOWER_KEY_TCP_FLAGS_MASK => {
-                if payload.len() != 2 {
+                let flags = parse_u16_be(payload)?;
+                if flags > 0xff {
                     return Err(DecodeError::from(
-                        "invalid tcp flags mask length",
+                        "invalid tcp flags mask value",
                     ));
                 }
-                let flags = BigEndian::read_u16(payload);
-                Self::KeyTcpFlagsMask(flags as u8)
+                Self::KeyTcpFlagsMask((flags & 0xff) as u8)
             }
             TCA_FLOWER_KEY_IP_TOS => {
                 if payload.len() != 1 {
@@ -2276,7 +2281,7 @@ impl Nla for Lse {
     }
 
     fn emit_value(&self, buffer: &mut [u8]) {
-        self.opts.as_slice().emit(buffer)
+        self.opts.as_slice().emit(buffer);
     }
 
     fn is_nested(&self) -> bool {
@@ -2486,6 +2491,9 @@ impl From<L2Miss> for u8 {
 pub struct MaintenanceDomainLevel(u8);
 
 impl MaintenanceDomainLevel {
+    /// # Errors
+    /// Returns an error if the value is greater than 7
+    /// (the maximum allowed value in the CFM spec).
     pub fn new(value: u8) -> Result<Self, DecodeError> {
         if value > 7 {
             Err(DecodeError::from("invalid maintenance domain level"))