Fix 'no-decorations' in Windows. #4359
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, an overlapped window that used
with_decorations(false)didn't have the proper styles.Previously, between other flags it removed
WS_CAPTIONbut only for child windows.That doesn't actually make sense, because
WS_CAPTIONis intended for overlapped (non-child) windows only. Actually its numeric value is equal toWS_BORDER | WS_DLGFRAME:That is why removing it actually removes the decoration of child windows (
WS_BORDER).Anyway, trying to create a secondary overlapped window without decorations doesn't work, I think because the styles are not actually removed, but the inner/outer metrics is fixed as if it were.
With this change the decorations are removed both for child and overlapped windows.
changelogmodule if knowledge of this change could be valuable to users