chore: data attribution footer + remove omeda.city hotlink#185
Merged
Conversation
- Remove external image fallback in HeroAvatar — local assets only, initials shown when image is missing (no hotlinking to omeda.city) - Add attribution footer in sidebar: pred.gg and omeda.city credited as data sources with links - Fix duplicate /management/roles route (ComingSoon was shadowing PermissionsPage) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué se hizo
Dos correcciones de cumplimiento identificadas en el informe de política de pred.gg/omeda.city.
1. Eliminar hotlink a omeda.city en HeroAvatar
HeroAvatar.tsxusabameta?.imageUrlcomo fallback cuando la imagen local fallaba — esa URL apunta aomeda.city/assets/.... Ahora solo se usan assets locales (/heroes/*.webp). Si la imagen local no existe, se muestran las iniciales del héroe (lógica ya existente).2. Atribución visible en footer del sidebar
Añadida una línea en la parte inferior del sidebar:
Match & player data: pred.gg · omeda.cityCon enlaces a ambos sitios. Visible en todas las páginas para todos los usuarios autenticados.
3. Fix ruta duplicada
/management/rolesHabía dos
<Route path="/management/roles">— la primera (ComingSoon) ganaba siempre, haciendo inaccesible la nueva PermissionsPage. Corregido.