feat: add no-template-children rule to recommended configuration (#74)

Author: rui-rayqiu

package.json

@@ -23,7 +23,7 @@
     "eslint-restricted-globals": "~0.2.0"
   },
   "devDependencies": {
-    "@lwc/eslint-plugin-lwc": "^1.0.0",
+    "@lwc/eslint-plugin-lwc": "^1.1.0",
     "@salesforce/eslint-plugin-lightning": "^0.1.0",
     "eslint": "^7.26.0",
     "eslint-plugin-import": "^2.23.2",

recommended.js

@@ -113,6 +113,7 @@ module.exports = {
         '@lwc/lwc/no-dupe-class-members': 'error',
         '@lwc/lwc/no-inner-html': 'error',
         '@lwc/lwc/no-leading-uppercase-api-name': 'error',
+        '@lwc/lwc/no-template-children': 'error',
         '@lwc/lwc/prefer-custom-event': 'error',
         '@lwc/lwc/valid-api': [
             'error',

test/recommended.js

@@ -110,6 +110,25 @@ describe('recommended config', () => {
         assert.strictEqual(messages[0].ruleId, '@lwc/lwc/no-attributes-during-construction');
     });
 
+    it('should prevent accessing the immediate children of this.template', () => {
+        const cli = getCliEngineWithRecommendedRules();
+
+        const report = cli.executeOnText(`
+            import { LightningElement } from 'lwc';
+
+            export default class App extends LightningElement {
+                renderedCallback() {
+                    const element = this.template.firstChild;
+                    element.focus();
+                }
+            }
+        `);
+
+        const { messages } = report.results[0];
+        assert.strictEqual(messages.length, 1);
+        assert.strictEqual(messages[0].ruleId, '@lwc/lwc/no-template-children');
+    });
+
     it('should prevent invalid usage of Apex method', () => {
         const cli = getCliEngineWithRecommendedRules();
 

yarn.lock

@@ -246,10 +246,10 @@
   resolved "https://registry.yarnpkg.com/@humanwhocodes/object-schema/-/object-schema-1.2.0.tgz#87de7af9c231826fdd68ac7258f77c429e0e5fcf"
   integrity sha512-wdppn25U8z/2yiaT6YGquE6X8sSv7hNMWSXYSSU1jGv/yd6XqjXgTDJ8KP4NgjTXfJ3GbRjeeb8RTV7a/VpM+w==
 
-"@lwc/eslint-plugin-lwc@^1.0.0":
-  version "1.0.1"
-  resolved "https://registry.yarnpkg.com/@lwc/eslint-plugin-lwc/-/eslint-plugin-lwc-1.0.1.tgz#6e8caf63d1ef60c26a609e8e9b836e1a5f454b14"
-  integrity sha512-BtVlcIc+Fc/G61lM0jixFSr5XNY4w4YjWigSlNHA1+wBEe0VZ/ByJpUZnePrLfHM4lYCl9qOs8t/6c8ZqK1ghA==
+"@lwc/eslint-plugin-lwc@^1.1.0":
+  version "1.1.0"
+  resolved "https://registry.yarnpkg.com/@lwc/eslint-plugin-lwc/-/eslint-plugin-lwc-1.1.0.tgz#e2c70252c4c52a3f66facca653f5f93e1dd66dc9"
+  integrity sha512-0oU9tDTX2qF9efmwhLKl5R4jJhZfU5gaHdtNiYxv0kqL5N22xxGO20+AV+ShLt4QocCO/wrq6RO+lnw0ZzqeTQ==
   dependencies:
     minimatch "^3.0.4"