Skip to content

Commit 96734a8

Browse files
authored
feat: add lwc/no-disallowed-lwc-imports rule (#93)
1 parent 0929075 commit 96734a8

File tree

4 files changed

+38
-11
lines changed

4 files changed

+38
-11
lines changed

base.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,5 +330,8 @@ module.exports = {
330330
adapters: WIRE_ADAPTERS_WITH_RESTRICTED_USE,
331331
},
332332
],
333+
334+
// LWC import validation
335+
'@lwc/lwc/no-disallowed-lwc-imports': 'error',
333336
},
334337
};

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"semver": "^7.3.5"
2525
},
2626
"devDependencies": {
27-
"@lwc/eslint-plugin-lwc": "^1.1.2",
27+
"@lwc/eslint-plugin-lwc": "^1.2.1",
2828
"@salesforce/eslint-plugin-lightning": "^1.0.0",
2929
"eslint": "^8.12.0",
3030
"eslint-plugin-import": "^2.25.4",

test/base.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,4 +85,21 @@ describe('base config', () => {
8585
assert.equal(messages.length, 1);
8686
assert.equal(messages[0].ruleId, '@lwc/lwc/no-unexpected-wire-adapter-usages');
8787
});
88+
89+
it('should include @lwc/lwc/no-disallowed-lwc-imports', async () => {
90+
const cli = new eslint.ESLint({
91+
useEslintrc: false,
92+
baseConfig: {
93+
extends: '@salesforce/eslint-config-lwc/base',
94+
},
95+
});
96+
97+
const results = await cli.lintText(`
98+
import { yolo } from 'lwc';
99+
`);
100+
101+
const { messages } = results[0];
102+
assert.equal(messages.length, 1);
103+
assert.equal(messages[0].ruleId, '@lwc/lwc/no-disallowed-lwc-imports');
104+
});
88105
});

yarn.lock

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -261,12 +261,12 @@
261261
"@jridgewell/resolve-uri" "^3.0.3"
262262
"@jridgewell/sourcemap-codec" "^1.4.10"
263263

264-
"@lwc/eslint-plugin-lwc@^1.1.2":
265-
version "1.1.2"
266-
resolved "https://registry.yarnpkg.com/@lwc/eslint-plugin-lwc/-/eslint-plugin-lwc-1.1.2.tgz#b3815e7030aa006751e99f28d4a6c153bba1eda8"
267-
integrity sha512-mkVTpyZhR+F5WHSe/wHiuw6AqOclXc8spWOddMvkYG07G21cSe8S8sxWk1cGkwa1V+yr/PaiABLcIFBOOSMI+A==
264+
"@lwc/eslint-plugin-lwc@^1.2.1":
265+
version "1.2.1"
266+
resolved "https://registry.yarnpkg.com/@lwc/eslint-plugin-lwc/-/eslint-plugin-lwc-1.2.1.tgz#4953dff14d2dabad22c967d4fd4b666ef45dbcd9"
267+
integrity sha512-13a5XOultegAc4i4SyFk9367KOvvRy40zbRSKkApcNa9uMI6n9/C/yFMvwve6Mp6PaIsGXlKFWNkzwj+nADEzw==
268268
dependencies:
269-
minimatch "^3.0.5"
269+
minimatch "^5.0.1"
270270

271271
"@nodelib/[email protected]":
272272
version "2.1.5"
@@ -485,6 +485,13 @@ brace-expansion@^1.1.7:
485485
balanced-match "^1.0.0"
486486
concat-map "0.0.1"
487487

488+
brace-expansion@^2.0.1:
489+
version "2.0.1"
490+
resolved "https://registry.yarnpkg.com/brace-expansion/-/brace-expansion-2.0.1.tgz#1edc459e0f0c548486ecf9fc99f2221364b9a0ae"
491+
integrity sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==
492+
dependencies:
493+
balanced-match "^1.0.0"
494+
488495
braces@^3.0.1, braces@~3.0.2:
489496
version "3.0.2"
490497
resolved "https://registry.yarnpkg.com/braces/-/braces-3.0.2.tgz#3454e1a462ee8d599e236df336cd9ea4f8afe107"
@@ -1591,12 +1598,12 @@ minimatch@^3.0.4:
15911598
dependencies:
15921599
brace-expansion "^1.1.7"
15931600

1594-
minimatch@^3.0.5:
1595-
version "3.1.2"
1596-
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-3.1.2.tgz#19cd194bfd3e428f049a70817c038d89ab4be35b"
1597-
integrity sha512-J7p63hRiAjw1NDEww1W7i37+ByIrOWO5XQQAzZ3VOcL0PNybwpfmV/N05zFAzwQ9USyEcX6t3UO+K5aqBQOIHw==
1601+
minimatch@^5.0.1:
1602+
version "5.0.1"
1603+
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-5.0.1.tgz#fb9022f7528125187c92bd9e9b6366be1cf3415b"
1604+
integrity sha512-nLDxIFRyhDblz3qMuq+SoRZED4+miJ/G+tdDrjkkkRnjAsBexeGpgjLEQ0blJy7rHhR2b93rhQY4SvyWu9v03g==
15981605
dependencies:
1599-
brace-expansion "^1.1.7"
1606+
brace-expansion "^2.0.1"
16001607

16011608
minimist@^1.2.0, minimist@^1.2.5:
16021609
version "1.2.6"

0 commit comments

Comments
 (0)