Merge pull request #24 from MKLeb/hotfix/no-signal-handling-on-windows

Catch NotImplementedError on loop.add_signal_handler for Windows

Author: s0undt3ch

changelog/24.bugfix.rst

@@ -0,0 +1 @@
+Catch `NotImplementedError` exception when setting up signal handling. Windows, for example, does not support signal handling with asyncio.

src/ptscripts/process.py

@@ -231,7 +231,11 @@ async def _subprocess_run(
     loop = asyncio.get_running_loop()
     for signame in ("SIGINT", "SIGTERM"):
         sig = getattr(signal, signame)
-        loop.add_signal_handler(sig, partial(_handle_signal, proc, sig))
+        try:
+            loop.add_signal_handler(sig, partial(_handle_signal, proc, sig))
+        except NotImplementedError:
+            # On Windows, `add_signal_handler` is not defined, so we catch and ignore
+            pass
     stdout, stderr = await asyncio.shield(proc.communicate())
     result = subprocess.CompletedProcess(
         args=cmdline,