Context
Code review of branch fix/valoper-signing-address-moniker. Non-blocking follow-up.
Problem
In enrichValoperSigningAddresses (internal/gnovalidator/valoper.go, ~L99-105), if a single valoper profile render errors, SigningAddress is left "". InitMonikerMap then keys that valoper only by its operator address. Because block precommits carry the signing address, that validator resolves to unknown until a later refresh happens to succeed — with only a log line to indicate it.
A transient RPC blip on one profile thus mislabels that validator's alerts/metrics/reports for the whole refresh interval (~5 min).
Suggested fix
Wrap the per-profile fetch in the existing doWithRetry helper (already in valoper.go), so a transient failure retries before giving up.
Severity: low-medium (transient silent degradation).
Context
Code review of branch
fix/valoper-signing-address-moniker. Non-blocking follow-up.Problem
In
enrichValoperSigningAddresses(internal/gnovalidator/valoper.go, ~L99-105), if a single valoper profile render errors,SigningAddressis left"".InitMonikerMapthen keys that valoper only by its operator address. Because block precommits carry the signing address, that validator resolves tounknownuntil a later refresh happens to succeed — with only a log line to indicate it.A transient RPC blip on one profile thus mislabels that validator's alerts/metrics/reports for the whole refresh interval (~5 min).
Suggested fix
Wrap the per-profile fetch in the existing
doWithRetryhelper (already invaloper.go), so a transient failure retries before giving up.Severity: low-medium (transient silent degradation).