Bulkrax Deletions sometimes raises error when finding ActiveFedora::Base objects using Solr keys

[maxkadel]

Originating issue comment

The relevant part of the stacktrace is:

["/usr/local/bundle/bundler/gems/rails-d16199e50708/activemodel/lib/active_model/attribute_methods.rb:469:in `method_missing'",
  "/usr/local/bundle/bundler/gems/bulkrax-204acd1249de/app/factories/bulkrax/object_factory.rb:119:in `block in search_by_property'",
  "/usr/local/bundle/gems/active-fedora-14.0.1/lib/active_fedora/relation.rb:152:in `block in each'",
  "/usr/local/bundle/gems/active-fedora-14.0.1/lib/active_fedora/relation/finder_methods.rb:119:in `block (2 levels) in find_each'",
  "/usr/local/bundle/gems/active-fedora-14.0.1/lib/active_fedora/relation/finder_methods.rb:118:in `each'",
  "/usr/local/bundle/gems/active-fedora-14.0.1/lib/active_fedora/relation/finder_methods.rb:118:in `block in find_each'",
  "/usr/local/bundle/gems/active-fedora-14.0.1/lib/active_fedora/relation/finder_methods.rb:154:in `block in search_in_batches'",
  "/usr/local/bundle/gems/active-fedora-14.0.1/lib/active_fedora/relation/finder_methods.rb:150:in `loop'",
  "/usr/local/bundle/gems/active-fedora-14.0.1/lib/active_fedora/relation/finder_methods.rb:150:in `search_in_batches'",
  "/usr/local/bundle/gems/active-fedora-14.0.1/lib/active_fedora/relation/finder_methods.rb:117:in `find_each'",
  "/usr/local/bundle/gems/active-fedora-14.0.1/lib/active_fedora/relation.rb:152:in `each'",
  "/usr/local/bundle/bundler/gems/bulkrax-204acd1249de/app/factories/bulkrax/object_factory.rb:114:in `detect'",
  "/usr/local/bundle/bundler/gems/bulkrax-204acd1249de/app/factories/bulkrax/object_factory.rb:114:in `search_by_property'",
  "/usr/local/bundle/bundler/gems/bulkrax-204acd1249de/app/services/wings/custom_queries/find_by_source_identifier.rb:26:in `find_by_property_value'",
  "/usr/local/bundle/gems/valkyrie-3.5.0/lib/valkyrie/persistence/custom_query_container.rb:55:in `block (2 levels) in register_query_handler'",
  "/usr/local/bundle/bundler/gems/bulkrax-204acd1249de/app/factories/bulkrax/valkyrie_object_factory.rb:189:in `search_by_property'",
  "/usr/local/bundle/bundler/gems/bulkrax-204acd1249de/app/factories/bulkrax/object_factory_interface.rb:377:in `search_by_identifier'",
  "/usr/local/bundle/bundler/gems/bulkrax-204acd1249de/app/factories/bulkrax/object_factory_interface.rb:324:in `find'",
  "/usr/local/bundle/bundler/gems/bulkrax-204acd1249de/app/factories/bulkrax/valkyrie_object_factory.rb:214:in `delete'",
  "/usr/local/bundle/bundler/gems/bulkrax-204acd1249de/app/jobs/bulkrax/delete_job.rb:9:in `perform'"]

I believe the fix may be in app/services/wings/custom_queries/find_by_source_identifier.rb in find_by_property_value by being sure to pass on both property and search_field to the Bulkrax::ObjectFactory.search_by_property method.

[laritakr]

The apparent underlying cause (documenting here for future reference):

The valkyrie resource was deleted but something failed in the DeleteJob before the Fedora record was removed. Since the valkyrie resource was gone when it reran, it fell back to the Fedora record, causing the same problem that occurs in an unmigrated tenant when trying to edit/delete with bulkrax: the valkyrie setting is on so it uses the valkyrie adapter, but with a Fedora record.

A quick fix is to gather the ids of all affected works and remigrate them. However this could obviously happen again.

The ideal solution would be to find a clean way to identify the record we have and fall back to the correct adapter. Doing this generically through the object factories, without breaking the non-requiring of Hyrax requires caution.