Non-FOGI-compatible functions

[juangmendoza19]

While playing around with FOGI models, I noticed that the method print_parameters_by_op(self, max_depth=0) in model.py has not been updated to work with FOGI models. To be more specific, it seems like self.parameter_labels cannot be expected to always hold operator parameter labels anymore, but model parameter labels.

Environment :

• pyGSTi v0.9.11.1

[sserita]

@juangmendoza19 Is this still a problem? The #488 PR makes it sounds like there are some FOGI labels in now, but I'm not sure if this is a different issue?

[juangmendoza19]

@juangmendoza19 Is this still a problem? The #488 PR makes it sounds like there are some FOGI labels in now, but I'm not sure if this is a different issue?

This is a different issue, although the PR you are referencing did change the behavior of this function with FOGI models. It still seems to not be working. This is the current output for a smq1Q_XY FOGI model:

fogi_model.print_parameters_by_op()

*** MODEL PARAMETERS (19 total) ***

rho0 [ComposedState]: 12 params, indices=slice(0, 12, None), 2 sub-members
0: X Hamiltonian error coefficient --> 1(Label(('Gxpi2', 0)), 'X Hamiltonian error coefficient')
1: Y Hamiltonian error coefficient --> 1(Label(('Gxpi2', 0)), 'X diagonal element of non-H coeff matrix')
2: Z Hamiltonian error coefficient --> 1(Label(('Gxpi2', 0)), 'Im[(Y,Z) element of non-H coeff matrix]')
3: X diagonal element of non-H coeff matrix --> 1(Label(('Gxpi2', 0)), 'Y diagonal element of non-H coeff matrix') + 1(Label(('Gxpi2', 0)), 'Z diagonal element of non-H coeff matrix')
4: Im[(X,Y) element of non-H coeff matrix] --> 1(Label(('Gypi2', 0)), 'Y Hamiltonian error coefficient')
5: Im[(X,Z) element of non-H coeff matrix] --> 1(Label(('Gypi2', 0)), 'Im[(X,Z) element of non-H coeff matrix]')
6: Re[(Y,X) element of non-H coeff matrix] --> 1(Label(('Gypi2', 0)), 'Y diagonal element of non-H coeff matrix')
7: Y diagonal element of non-H coeff matrix --> 1(Label(('Gypi2', 0)), 'X diagonal element of non-H coeff matrix') + 1(Label(('Gypi2', 0)), 'Z diagonal element of non-H coeff matrix')
8: Im[(Y,Z) element of non-H coeff matrix] --> 0.57735(Label(('Gxpi2', 0)), 'Re[(Z,Y) element of non-H coeff matrix]') + 0.57735(Label(('Gypi2', 0)), 'Re[(Y,X) element of non-H coeff matrix]') + -0.57735(Label(('Gypi2', 0)), 'Re[(Z,Y) element of non-H coeff matrix]')
9: Re[(Z,X) element of non-H coeff matrix] --> -0.5(Label(('Gxpi2', 0)), 'Im[(X,Y) element of non-H coeff matrix]') + 0.5(Label(('Gxpi2', 0)), 'Im[(X,Z) element of non-H coeff matrix]') + 0.5(Label(('Gypi2', 0)), 'Im[(X,Y) element of non-H coeff matrix]') + -0.5(Label(('Gypi2', 0)), 'Im[(Y,Z) element of non-H coeff matrix]')
10: Re[(Z,Y) element of non-H coeff matrix] --> -0.57735(Label(('Gxpi2', 0)), 'Re[(Y,X) element of non-H coeff matrix]') + -0.57735(Label(('Gxpi2', 0)), 'Re[(Z,X) element of non-H coeff matrix]') + 0.57735(Label(('Gypi2', 0)), 'Re[(Z,X) element of non-H coeff matrix]')
11: Z diagonal element of non-H coeff matrix --> -0.5(Label(('Gxpi2', 0)), 'Re[(Y,X) element of non-H coeff matrix]') + 0.5(Label(('Gxpi2', 0)), 'Re[(Z,X) element of non-H coeff matrix]') + 0.5(Label(('Gypi2', 0)), 'Re[(Y,X) element of non-H coeff matrix]') + 0.5(Label(('Gypi2', 0)), 'Re[(Z,Y) element of non-H coeff matrix]')
Mdefault [ComposedPOVM]: 12 params, indices=slice(12, 24, None), 2 sub-members
12: X Hamiltonian error coefficient --> 0.5(Label(('Gxpi2', 0)), 'Y Hamiltonian error coefficient') + 0.5(Label(('Gxpi2', 0)), 'Z Hamiltonian error coefficient') + 0.5(Label(('Gypi2', 0)), 'X Hamiltonian error coefficient') + -0.5(Label(('Gypi2', 0)), 'Z Hamiltonian error coefficient')
13: Y Hamiltonian error coefficient --> 0.816497(Label('Mdefault'), 'Im[(X,Y) element of non-H coeff matrix]') + 0.408248(Label(('Gxpi2', 0)), 'Im[(X,Y) element of non-H coeff matrix]') + -0.408248(Label(('Gxpi2', 0)), 'Im[(X,Z) element of non-H coeff matrix]')
14: Z Hamiltonian error coefficient --> 0.57735(Label('Mdefault'), 'Y Hamiltonian error coefficient') + -0.57735(Label('Mdefault'), 'Re[(Z,X) element of non-H coeff matrix]') + 0.288675(Label(('Gxpi2', 0)), 'Y Hamiltonian error coefficient') + -0.288675(Label(('Gxpi2', 0)), 'Z Hamiltonian error coefficient') + -0.288675(Label(('Gxpi2', 0)), 'Re[(Y,X) element of non-H coeff matrix]') + -0.288675(Label(('Gxpi2', 0)), 'Re[(Z,X) element of non-H coeff matrix]')
15: X diagonal element of non-H coeff matrix --> 0.57735(Label('Mdefault'), 'X Hamiltonian error coefficient') + 0.57735(Label('Mdefault'), 'Re[(Z,Y) element of non-H coeff matrix]') + 0.288675(Label(('Gypi2', 0)), 'X Hamiltonian error coefficient') + 0.288675(Label(('Gypi2', 0)), 'Z Hamiltonian error coefficient') + -0.288675(Label(('Gypi2', 0)), 'Re[(Y,X) element of non-H coeff matrix]') + 0.288675(Label(('Gypi2', 0)), 'Re[(Z,Y) element of non-H coeff matrix]')
16: Im[(X,Y) element of non-H coeff matrix] --> 0.288675(Label('rho0'), 'X diagonal element of non-H coeff matrix') + 0.57735(Label('rho0'), 'Im[(X,Y) element of non-H coeff matrix]') + 0.288675(Label('rho0'), 'Y diagonal element of non-H coeff matrix') + 0.288675(Label('Mdefault'), 'X diagonal element of non-H coeff matrix') + 0.57735(Label('Mdefault'), 'Im[(X,Y) element of non-H coeff matrix]') + 0.288675(Label('Mdefault'), 'Y diagonal element of non-H coeff matrix')
17: Im[(X,Z) element of non-H coeff matrix] --> -0.116248(Label('rho0'), 'Y Hamiltonian error coefficient') + 0.232495(Label('rho0'), 'Im[(Y,Z) element of non-H coeff matrix]') + -0.116248(Label('rho0'), 'Re[(Z,X) element of non-H coeff matrix]') + 0.0581238(Label(('Gxpi2', 0)), 'Y Hamiltonian error coefficient') + -0.0581238(Label(('Gxpi2', 0)), 'Z Hamiltonian error coefficient') + -0.523114(Label(('Gxpi2', 0)), 'Re[(Y,X) element of non-H coeff matrix]') + -0.523114(Label(('Gxpi2', 0)), 'Re[(Z,X) element of non-H coeff matrix]') + -0.116248(Label(('Gypi2', 0)), 'Im[(X,Y) element of non-H coeff matrix]') + -0.116248(Label(('Gypi2', 0)), 'Im[(Y,Z) element of non-H coeff matrix]') + 0.581238(Label(('Gypi2', 0)), 'Re[(Z,X) element of non-H coeff matrix]')
18: Re[(Y,X) element of non-H coeff matrix] --> 0.116248(Label('rho0'), 'X Hamiltonian error coefficient') + -0.232495(Label('rho0'), 'Im[(X,Z) element of non-H coeff matrix]') + -0.116248(Label('rho0'), 'Re[(Z,Y) element of non-H coeff matrix]') + 0.116248(Label(('Gxpi2', 0)), 'Im[(X,Y) element of non-H coeff matrix]') + 0.116248(Label(('Gxpi2', 0)), 'Im[(X,Z) element of non-H coeff matrix]') + 0.581238(Label(('Gxpi2', 0)), 'Re[(Z,Y) element of non-H coeff matrix]') + -0.0581238(Label(('Gypi2', 0)), 'X Hamiltonian error coefficient') + -0.0581238(Label(('Gypi2', 0)), 'Z Hamiltonian error coefficient') + 0.523114(Label(('Gypi2', 0)), 'Re[(Y,X) element of non-H coeff matrix]') + -0.523114(Label(('Gypi2', 0)), 'Re[(Z,Y) element of non-H coeff matrix]')
19: Y diagonal element of non-H coeff matrix
20: Im[(Y,Z) element of non-H coeff matrix]
21: Re[(Z,X) element of non-H coeff matrix]
22: Re[(Z,Y) element of non-H coeff matrix]
23: Z diagonal element of non-H coeff matrix
Gxpi2:0 [ComposedOp]: 12 params, indices=slice(24, 36, None), 2 sub-members
24: X Hamiltonian error coefficient
25: Y Hamiltonian error coefficient
26: Z Hamiltonian error coefficient
27: X diagonal element of non-H coeff matrix
28: Im[(X,Y) element of non-H coeff matrix]
29: Im[(X,Z) element of non-H coeff matrix]
30: Re[(Y,X) element of non-H coeff matrix]
31: Y diagonal element of non-H coeff matrix
32: Im[(Y,Z) element of non-H coeff matrix]
33: Re[(Z,X) element of non-H coeff matrix]
34: Re[(Z,Y) element of non-H coeff matrix]
35: Z diagonal element of non-H coeff matrix
Gypi2:0 [ComposedOp]: 12 params, indices=slice(36, 48, None), 2 sub-members
36: X Hamiltonian error coefficient
37: Y Hamiltonian error coefficient
38: Z Hamiltonian error coefficient
39: X diagonal element of non-H coeff matrix
40: Im[(X,Y) element of non-H coeff matrix]
41: Im[(X,Z) element of non-H coeff matrix]
42: Re[(Y,X) element of non-H coeff matrix]
43: Y diagonal element of non-H coeff matrix
44: Im[(Y,Z) element of non-H coeff matrix]
45: Re[(Z,X) element of non-H coeff matrix]
46: Re[(Z,Y) element of non-H coeff matrix]
47: Z diagonal element of non-H coeff matrix