Merge pull request #170 from insertinterestingnamehere/warnings

Fix Warnings

Author: insertinterestingnamehere

.github/workflows/CI.yml

@@ -133,6 +133,8 @@ jobs:
     env:
       CC: icc
       CXX: icpc
+      CFLAGS: "-diag-disable=10441"
+      CXXFLAGS: "-diag-disable=10441"
     steps:
     - uses: actions/checkout@v3
     - if: ${{ matrix.topology != 'no' }}

config/qthread_check_FUNCTION.m4

@@ -7,7 +7,7 @@ AC_DEFUN([QTHREAD_CHECK_FUNCTION],
 			             [qt_cv_c99_FUNCTION],
 						 [AC_TRY_COMPILE(
 [#include <stdio.h>
-void foo(void) { printf("%s\n", __FUNCTION__); }],
+static void foo(void) { printf("%s\n", __FUNCTION__); }],
     [foo(); return 0;],
     [qt_cv_c99_FUNCTION=yes],
     [qt_cv_c99_FUNCTION=no])])
@@ -16,7 +16,7 @@ void foo(void) { printf("%s\n", __FUNCTION__); }],
 	[qt_cv_c99_func],
 	[AC_TRY_COMPILE(
 [#include <stdio.h>
-void foo(void) { printf("%s\n", __func__); }],
+static void foo(void) { printf("%s\n", __func__); }],
 	[foo(); return 0;],
 	[qt_cv_c99_func=yes],
 	[qt_cv_c99_func=no])])

config/qthread_check_assembly.m4

@@ -133,7 +133,7 @@ AC_DEFUN([QTHREAD_CHECK_INLINE_C_GCC],[
   asm_result="unknown"
   AS_IF([test ! "$assembly" = ""],
         [AC_RUN_IFELSE([AC_LANG_SOURCE([[
-int main() {
+int main(void) {
 int ret = 1;
 __asm__ __volatile__ ($assembly);
 return ret;
@@ -145,7 +145,7 @@ return ret;
   # if we're cross compiling, just try to compile and figure good enough
   AS_IF([test "$asm_result" = "unknown"],
     [AC_LINK_IFELSE([AC_LANG_SOURCE([[
-int main()
+int main(void)
 {
 int ret = 1;
 __asm__ __volatile__ ($assembly);

config/qthread_check_atomics.m4

@@ -29,7 +29,7 @@ AC_CACHE_CHECK([whether compiler supports builtin atomic CAS-32],
 #include <stdlib.h>
 #include <stdint.h> /* for uint32_t */
 
-int main()
+int main(void)
 {
 uint32_t bar=1, old=1, new=2;
 uint32_t foo = __sync_val_compare_and_swap(&bar, old, new);
@@ -48,7 +48,7 @@ AC_CACHE_CHECK([whether compiler supports builtin atomic CAS-64],
 #include <stdlib.h>
 #include <stdint.h> /* for uint64_t */
 
-int main()
+int main(void)
 {
 uint64_t bar=1, old=1, new=2;
 uint64_t foo = __sync_val_compare_and_swap(&bar, old, new);
@@ -66,7 +66,7 @@ AC_CACHE_CHECK([whether compiler supports builtin atomic CAS-ptr],
 #endif
 #include <stdlib.h>
 
-int main()
+int main(void)
 {
 void *bar=(void*)1, *old=(void*)1, *new=(void*)2;
 void *foo = __sync_val_compare_and_swap(&bar, old, new);
@@ -138,7 +138,7 @@ AC_CACHE_CHECK([whether compiler supports builtin atomic incr],
 #include <stdlib.h>
 #include <stdint.h> /* for uint64_t */
 
-int main()
+int main(void)
 {
 uint64_t bar=1;
 uint64_t foo = __sync_fetch_and_add(&bar, 1);
@@ -155,7 +155,7 @@ return foo;
 #include <stdlib.h>
 #include <stdint.h> /* for uint32_t */
 
-int main()
+int main(void)
 {
 uint32_t bar=1;
 uint32_t foo = __sync_fetch_and_add(&bar, 1);
@@ -180,7 +180,6 @@ AS_IF([test "$qthread_cv_atomic_incr" = "yes"],
 int main(int argc, char *argv[])
 {
 uint64_t master = 0;
-uint64_t test;
 if ((__sync_fetch_and_add(&master, 1) != 0) || (master != 1)) {
   return -1;
 }
@@ -213,7 +212,7 @@ return 0;
 #include <stdlib.h>
 #include <stdint.h> /* for uint32_t */
 
-int main()
+int main(void)
 {
 uint64_t master = 0;
 if ((__sync_fetch_and_add(&master, 1) != 0) || (master != 1)) {
@@ -231,7 +230,7 @@ AS_IF([test "$qthread_cv_atomic_CAS" = "yes"],
 		[AC_LINK_IFELSE([AC_LANG_SOURCE([[
 #include <stdlib.h>
 
-int main()
+int main(void)
 {
 long bar=1, old=1, new=2;
 long foo = __sync_val_compare_and_swap(&bar, old, new);

config/qthread_check_attributes.m4

@@ -11,6 +11,7 @@ AC_CACHE_CHECK(
  [qt_cv_aligned_attr],
  [AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
 int foo __attribute__((aligned(64)));
+int f(int i);
 int f(int i) { foo = 1; return foo; }]])],
  [qt_cv_aligned_attr=yes],
  [qt_cv_aligned_attr=no])])
@@ -25,8 +26,10 @@ AC_CACHE_CHECK(
  [support for __attribute__((malloc))],
  [qt_cv_malloc_attr],
  [AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
-__attribute__((malloc))
-void * f(int i) { return malloc(i); }]])],
+#include <stdlib.h>
+__attribute__((malloc)) void * f(int i);
+__attribute__((malloc)) void * f(int i)
+{ return malloc(i); }]])],
  [qt_cv_malloc_attr=yes],
  [qt_cv_malloc_attr=no])])
  AS_IF([test "x$qt_cv_malloc_attr" = xyes],
@@ -42,7 +45,7 @@ AC_CACHE_CHECK(
  [support for __attribute__((unused))],
  [qt_cv_unused_attr],
  [AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
-__attribute__((unused))
+static __attribute__((unused))
 int f(int i) { return i; }]])],
  [qt_cv_unused_attr=yes],
  [qt_cv_unused_attr=no])])
@@ -60,8 +63,10 @@ AC_CACHE_CHECK(
  [support for __attribute__((noinline))],
  [qt_cv_noinline_attr],
  [AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
-__attribute__((noinline))
-void * f(int i) { return malloc(i); }]])],
+#include <stdlib.h>
+__attribute__((noinline)) void * f(int i);
+__attribute__((noinline)) void * f(int i)
+{ return malloc(i); }]])],
  [qt_cv_noinline_attr=yes],
  [qt_cv_noinline_attr=no])])
  AS_IF([test "x$qt_cv_noinline_attr" = xyes],
@@ -77,6 +82,8 @@ AC_CACHE_CHECK(
  [support for __attribute__((deprecated))],
  [qt_cv_deprecated_attr],
  [AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
+#include <stdlib.h>
+void * __attribute__((deprecated)) f (int i);
 void * __attribute__((deprecated)) f (int i)
 { return malloc(i); }]])],
  [qt_cv_deprecated_attr=yes],

config/qthread_check_bitfield_order.m4

@@ -27,13 +27,13 @@ union foo {
         unsigned b : 3;
         unsigned c : 1;
     } s;
-} fb;]],
-[[
-struct sigaction sa;
-void handler (int sig, siginfo_t* s, void* v)
+} fb;
+static void handler (int sig, siginfo_t* s, void* v)
 {
     _exit(1);
-}
+}]],
+[[
+struct sigaction sa;
 
 memset (&sa, '\0', sizeof(sa));
 sa.sa_sigaction = &handler;

config/qthread_check_pthreads.m4

@@ -11,8 +11,8 @@ AC_CACHE_CHECK(
  [qt_cv_pthread_process_private],
  [AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
 #include <pthread.h>
-pthread_mutex_t foo;
-int f(int i) { pthread_mutex_init(&foo, PTHREAD_PROCESS_PRIVATE); }]])],
+int val = PTHREAD_PROCESS_PRIVATE;
+]])],
  [qt_cv_pthread_process_private=yes],
  [qt_cv_pthread_process_private=no])])
  AS_IF([test "x$qt_cv_pthread_process_private" = xyes],

config/qthread_check_qsort.m4

@@ -22,18 +22,18 @@ AC_CHECK_FUNCS([qsort_r],
 
 struct sigaction sa;
 
-int cmp(void *a, const void *b, const void*c)
+static int cmp(void *a, const void *b, const void*c)
 {
   assert(a == NULL);
   return *(int*)b - *(int*)c;
 }
 
-void handler(int sig, siginfo_t* s, void* v)
+static void handler(int sig, siginfo_t* s, void* v)
 {
     _exit(1);
 }
 
-void register_handle()
+static void register_handle(void)
 {
     memset (&sa, '\0', sizeof(sa));
     sa.sa_sigaction = &handler;
@@ -42,7 +42,7 @@ void register_handle()
     sigaction(SIGSEGV, &sa, NULL); 
 }
 
-int main()
+int main(void)
 {
     int array[5] = {7,3,5,2,8};
     int i;

config/qthread_check_working_valloc.m4

@@ -17,7 +17,7 @@ AC_DEFUN([QTHREAD_CHECK_WORKING_VALLOC],
 # include <unistd.h>
 #endif
 
-int main()
+int main(void)
 {
   int i;
   char * allocs[100];

include/Makefile.am

@@ -36,6 +36,7 @@ noinst_HEADERS = \
 	qt_int_log.h \
 	qt_io.h \
 	qt_feb.h \
+        qt_locks.h \
 	qt_syncvar.h \
 	qt_macros.h \
 	qt_mpool.h \