Skip to content

Commit f07dff6

Browse files
erikjleeNoah Evans
authored andcommitted
debugging valgrind issues, no resolution.
1 parent 44b5010 commit f07dff6

File tree

2 files changed

+15
-10
lines changed

2 files changed

+15
-10
lines changed

include/qthread/performance.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -663,18 +663,20 @@ bool qtperf_check_invariants(void);
663663
#ifdef QTHREAD_PERFORMANCE
664664
#define QTPERF_ENTER_STATE(...) qtperf_enter_state(__VA_ARGS__)
665665
#define QTPERF_WORKER_ENTER_STATE(pdata,state) do{ \
666-
if(qtperf_should_instrument_workers){\
667-
QTPERF_ASSERT(pdata != NULL);\
668-
qtperf_enter_state(pdata, state);\
666+
if(qtperf_should_instrument_workers){ \
667+
QTPERF_ASSERT(pdata != NULL); \
668+
qtperf_enter_state(pdata, state); \
669669
} } while(0)
670-
#define QTPERF_QTHREAD_ENTER_STATE(pdata,state) do{ \
671-
if(qtperf_should_instrument_qthreads){ \
672-
QTPERF_ASSERT(pdata != NULL);\
673-
qtperf_enter_state(pdata, state);\
670+
#define QTPERF_QTHREAD_ENTER_STATE(pdata,state) do{ \
671+
if(qtperf_should_instrument_qthreads){ \
672+
QTPERF_ASSERT(pdata != NULL); \
673+
qtperf_enter_state(pdata, state); \
674674
}} while(0)
675675

676676
#else
677677
# define QTPERF_ENTER_STATE(...)
678+
# define QTPERF_QTHREAD_ENTER_STATE(...)
679+
# define QTPERF_WORKER_ENTER_STATE(...)
678680
#endif // ifdef QTHREAD_PERFORMANCE
679681

680682

test/perf/Makefile

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@ QTH_INC=$(QTHREADS)/include
44
QTH_LIB=$(QTHREADS)/src/.libs
55
CMOCK_LIB=${QTHREADS}/dependencies/install/lib
66
CMOCK_INC=${QTHREADS}/dependencies/install/include
7+
PKGLIB=${QTHREADS}/dependencies/install/lib/pkgconfig
78

8-
CFLAGS_OPT=-I$(QTH_INC) -I${CMOCK_INC} -O3 -Wall -pedantic -DPERFDBG=1 -DQTPERF_TESTING -DQTHREAD_PERFORMANCE -DQTHREAD_NONLAZY_THREADIDS=1 -g $(shell pkg-config --cflags cmocka)
9-
CFLAGS_DBG=-I$(QTH_INC) -I${CMOCK_INC} -Wall -pedantic -DPERFDBG=1 -DQTPERF_TESTING -DQTHREAD_PERFORMANCE -DQTHREAD_NONLAZY_THREADIDS=1 -g $(shell pkg-config --cflags cmocka)
9+
CFLAGS_OPT=-I$(QTH_INC) -I${CMOCK_INC} -O3 -Wall -DPERFDBG=1 -DQTPERF_TESTING -DQTHREAD_PERFORMANCE -DQTHREAD_NONLAZY_THREADIDS=1 -g
10+
CFLAGS_DBG=-I$(QTH_INC) -I${CMOCK_INC} -Wall -DPERFDBG=1 -DQTPERF_TESTING -DQTHREAD_PERFORMANCE -DQTHREAD_NONLAZY_THREADIDS=1 -g
1011
CFLAGS_NOPERF=-I$(QTH_INC) -DQTHREAD_NONLAZY_THREADIDS=1 -g
11-
CFLAGS=${CFLAGS_DBG}
12+
CFLAGS=-std=c99 ${CFLAGS_DBG}
1213

1314
LDFLAGS=-L$(QTH_LIB) -lqthread -L${CMOCK_LIB} -lcmocka
1415
TESTS=$(shell ls test_*.c)
@@ -28,6 +29,8 @@ check: all
2829
%.o: %.c
2930
gcc -c -o $*.o $(CFLAGS) $*.c
3031

32+
check-%: all
33+
LD_LIBRARY_PATH="${LIBPATH}" QT_NUM_SHEPHERDS=9 valgrind -q --read-var-info --leak-check=full ./$*.test
3134

3235
clean:
3336
rm -f *~ *.o ${TARGETS}

0 commit comments

Comments
 (0)