Using '/' as a target in the CODEOWNERS file doesn't match anything.

[tjoneslo]

This may be a user error on our part or a disagreement about the interpretation of the CODEOWNER spec.

If I have a CODEOWNERS file with the first line of / it doesn't match anything. Accord to one part of the spec, having a path ending with a / should match everything in the directory, and all sub-directories. By extension just a / should match everything in the repository.

from codeowners import CodeOwners
code_file = '''
... / @ORG/MyTeam
... '''
codeowner = CodeOwners(code_file)
codeowner.of("build.config")
[]

[sbdchd]

Does using /* do what you want?

With this lib I'm hoping to keep compatibility with github's behavior -- how does github handle the /?

The spec doesn't seem to mention /: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax

[tjoneslo]

It mentions it as one of the examples:

# In this example, @doctocat owns any file in the `/docs`
# directory in the root of your repository and any of its
# subdirectories.
/docs/ @doctocat

Which, by logical extension, would be / matches all the files in the root directory and any sub-directory. The example explicitly uses * as the default match all files in the whole repo.

[sbdchd]

Interesting, when I setup / as the pattern git's ignore setup doesn't consider /foo, bar/buzz, buzz.js, /a/b/c/d/e/f.txt to match

this test checks the pattern matching using git as the source of truth:

codeowners/codeowners/test_codeowners.py

Lines 513 to 536 in 6253a0c

	@pytest.mark.parametrize(
	"name,pattern,paths", GO_CODEOWNER_EXAMPLES, ids=ids_for(GO_CODEOWNER_EXAMPLES)
	)
	def test_specific_patterns_against_git(
	name: str, pattern: str, paths: Dict[str, bool]
	) -> None:
	"""
	Ensure the expected patterns match actual git behavior.
	Codeowners is a subset of git ignore behavior so checking against it
	should work in most cases.
	"""
	assert paths
	with tempfile.TemporaryDirectory() as directory:
	subprocess.run(["git", "init"], cwd=directory, check=True, capture_output=True)
	(Path(directory) / ".gitignore").write_text(pattern + "\n")
	for path, expected in paths.items():
	res = subprocess.run(
	["git", "check-ignore", path], cwd=directory, capture_output=True
	)
	actual = res.returncode == 0
	assert (
	actual is expected
	), f"match for pattern:{pattern} and path:{path} failed, expected: {expected}, actual: {actual}"