Settings: move fromCliArgs into class

Otherwise, we could inadvertently completely override all settings
instead of modifying them.

Author: kitbellew

cli/src/main/scala/mdoc/internal/cli/Settings.scala

@@ -247,6 +247,18 @@ case class Settings(
       cwd = dir
     )
   }
+
+  def withCliArgs(args: List[String]): Configured[Settings] = {
+    Conf.parseCliArgs[Settings](args).andThen { conf =>
+      val propsFile = conf.get[String]("propertyFileName").getOrElse("mdoc.properties")
+      val base = conf.get[String]("cwd").map { x =>
+        implicit val defaultCwd: AbsolutePath = this.cwd
+        withWorkingDirectory(AbsolutePath(x))
+      }.getOrElse(this).withPropertiesFromFile(propsFile)
+      conf.as[Settings](Settings.decoder(base)).map(_.addSite(base.site))
+    }
+  }
+
 }
 
 object Settings { // extends MetaconfigScalametaImplicits with Decoders with SettingsGeneric {
@@ -306,20 +318,8 @@ object Settings { // extends MetaconfigScalametaImplicits with Decoders with Set
     generic.deriveDecoder[Settings](base)
   }
 
-  def fromCliArgs(args: List[String], workingDirectory: => AbsolutePath): Configured[Settings] = {
-    Conf
-      .parseCliArgs[Settings](args)
-      .andThen { conf =>
-        implicit val defaultCwd: AbsolutePath = workingDirectory
-        val base = Settings(
-          conf.get[String]("cwd").map(AbsolutePath(_)).getOrElse(defaultCwd),
-          conf.get[String]("propertyFileName").getOrElse("mdoc.properties")
-        )
-        conf
-          .as[Settings](decoder(base))
-          .map(_.addSite(base.site))
-      }
-  }
+  def fromCliArgs(args: List[String], workingDirectory: AbsolutePath): Configured[Settings] =
+    Settings(workingDirectory).withCliArgs(args)
 
   def fromCliArgs(args: List[String], workingDirectory: Path): Configured[Settings] =
     fromCliArgs(args, AbsolutePath(workingDirectory))

mdoc/src/main/scala/mdoc/MainSettings.scala

@@ -23,9 +23,9 @@ final class MainSettings private (
   def withArgs(args: List[String]): MainSettings = {
     if (args.isEmpty) this
     else {
-      Settings.fromCliArgs(args, settings.cwd.toNIO) match {
+      settings.withCliArgs(args) match {
         case Configured.Ok(newSettings) =>
-          copy(settings = newSettings)
+          if (newSettings eq settings) this else copy(settings = newSettings)
         case Configured.NotOk(error) =>
           throw new IllegalArgumentException(error.toString())
       }