Skip to content

Commit 8992e91

Browse files
author
Marcin Czarnecki
committed
Update PHP test versions
1 parent 0ebbd52 commit 8992e91

File tree

5 files changed

+11
-10
lines changed

5 files changed

+11
-10
lines changed

.github/FUNDING.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
github: [goetas]
1+
github: [goetas, scyzoryck]
22
#patreon: goetas
33
#open_collective: jms-serializer
44
#ko_fi: # Replace with a single Ko-fi username

.github/workflows/ci.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@ jobs:
2020
- "8.1"
2121
- "8.2"
2222
- "8.3"
23+
- "8.4"
2324
dependencies:
2425
- "lowest"
2526
- "highest"
2627
include:
27-
- php-version: '8.4'
28+
- php-version: '8.5'
2829
dependencies: 'highest'
2930
composer-stability: 'dev'
3031

src/Handler/UnionHandler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ private function testPrimitive(mixed $data, string $type): bool
134134

135135
case 'bool':
136136
case 'boolean':
137-
return (string) (bool) $data === (string) $data;
137+
return !is_array($data) && (string) (bool) $data === (string) $data;
138138

139139
case 'true':
140140
return true === $data;

tests/Handler/EnumHandlerTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ protected function setUp(): void
3232

3333
public function testOrdinaryEnumCanNotBeUsedAsBackedEnumWhenSerializing()
3434
{
35-
self::expectException(InvalidMetadataException::class);
36-
self::expectExceptionMessage(sprintf('The type "%s" is not a backed enum, thus you can not use "value" as serialization mode for its value.', Suit::class));
35+
$this->expectException(InvalidMetadataException::class);
36+
$this->expectExceptionMessage(sprintf('The type "%s" is not a backed enum, thus you can not use "value" as serialization mode for its value.', Suit::class));
3737

3838
$visitor = $this->createMock(SerializationVisitorInterface::class);
3939
$context = $this->createMock(SerializationContext::class);
@@ -46,8 +46,8 @@ public function testOrdinaryEnumCanNotBeUsedAsBackedEnumWhenSerializing()
4646

4747
public function testOrdinaryEnumCanNotBeUsedAsBackedEnumWhenDeserializing()
4848
{
49-
self::expectException(InvalidMetadataException::class);
50-
self::expectExceptionMessage(sprintf('The type "%s" is not a backed enum, thus you can not use "value" as serialization mode for its value.', Suit::class));
49+
$this->expectException(InvalidMetadataException::class);
50+
$this->expectExceptionMessage(sprintf('The type "%s" is not a backed enum, thus you can not use "value" as serialization mode for its value.', Suit::class));
5151

5252
$visitor = $this->createMock(DeserializationVisitorInterface::class);
5353
$type = [

tests/Serializer/BaseSerializationTestCase.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ public function testExcludeIfOnClass()
349349
$serialized = $serializer->serialize($accounts, $this->getFormat(), null, sprintf('array<%s>', PersonAccountWithParent::class));
350350
$deserialized = $serializer->deserialize($serialized, sprintf('array<%s>', PersonAccountWithParent::class), $this->getFormat());
351351

352-
$this->assertEquals(1, count($deserialized));
352+
$this->assertCount(1, $deserialized);
353353
$this->assertEquals($accountNotExpired->name, $deserialized[0]->name);
354354
}
355355

@@ -419,7 +419,7 @@ public function testExcludeIfOnClassWithParent()
419419
$serialized = $serializer->serialize($accounts, $this->getFormat(), null, sprintf('array<%s>', PersonAccountWithParent::class));
420420
$deserialized = $serializer->deserialize($serialized, sprintf('array<%s>', PersonAccountWithParent::class), $this->getFormat());
421421

422-
$this->assertEquals(1, count($deserialized));
422+
$this->assertCount(1, $deserialized);
423423
$this->assertEquals($accountNotExpired->name, $deserialized[0]->name);
424424
}
425425

@@ -444,7 +444,7 @@ public function testExcludeIfOnParentClass()
444444
$serialized = $serializer->serialize($accounts, $this->getFormat(), null, sprintf('array<%s>', PersonAccountOnParent::class));
445445
$deserialized = $serializer->deserialize($serialized, sprintf('array<%s>', PersonAccountOnParent::class), $this->getFormat());
446446

447-
$this->assertEquals(1, count($deserialized));
447+
$this->assertCount(1, $deserialized);
448448
$this->assertEquals($accountNotExpired->name, $deserialized[0]->name);
449449
}
450450

0 commit comments

Comments
 (0)