Skip to content

Commit b7e812a

Browse files
authored
Merge pull request #61 from scientificcomputing/remove-petsc4py-typing
Remove petsc4py.typing
2 parents 62f0c07 + 7903f84 commit b7e812a

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/scifem/solvers.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from petsc4py import PETSc
99
import ufl
1010
import dolfinx
11-
import petsc4py.typing
1211

1312

1413
__all__ = ["NewtonSolver"]
@@ -99,7 +98,7 @@ def set_post_solve_callback(self, callback: Callable[["NewtonSolver"], None]):
9998
"""Set a callback function that is called after each Newton iteration."""
10099
self._post_solve_callback = callback
101100

102-
def solve(self, atol=1e-6, rtol=1e-6, beta=1.0) -> int:
101+
def solve(self, atol=1e-6, rtol=1e-8, beta=1.0) -> int:
103102
"""Solve the nonlinear problem using Newton's method.
104103
105104
Args:
@@ -205,15 +204,15 @@ def solve(self, atol=1e-6, rtol=1e-6, beta=1.0) -> int:
205204
self._post_solve_callback(self)
206205

207206
# Compute norm of update
208-
residual = self.dx.norm(petsc4py.typing.NormType.NORM_2)
207+
residual = self.dx.norm(PETSc.NormType.NORM_2)
209208
if i == 1:
210209
self.residual_0 = residual
211210
relative_residual = residual / max(self.residual_0, atol)
212211

213212
logger.info(
214213
f"Newton iteration {i}"
215-
f": r (abs) = {residual} (tol = {atol}), "
216-
f"r (rel) = {relative_residual}(tol = {rtol})"
214+
f": r (abs) = {residual} (tol={atol}), "
215+
f"r (rel) = {relative_residual} (tol={rtol})"
217216
)
218217
if relative_residual < rtol or residual < atol:
219218
return i

0 commit comments

Comments
 (0)