Skip to content

Commit 67b96f0

Browse files
authored
fix(types): allow running from Python 3.7 (#542)
1 parent a2a7205 commit 67b96f0

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

docs/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# What's new in boost-histogram
22

3+
## UPCOMING
4+
5+
* Support running type checking from Python < 3.8 [#542][]
6+
7+
[#542]: https://github.com/scikit-hep/boost-histogram/pull/542
8+
39
## Version 1.0
410

511
### Version 1.0.1

src/boost_histogram/_core/accumulators.pyi

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class WeightedSum(_BaseAccumulator):
1919
def value(self) -> float: ...
2020
@property
2121
def variance(self) -> float: ...
22-
def __iadd__(self: T, val: float, /) -> T: ...
22+
def __iadd__(self: T, arg0: float) -> T: ...
2323
def fill(self: T, value: ArrayLike, variance: ArrayLike | None = None) -> T: ...
2424
@staticmethod
2525
def _make(self: T, a: ArrayLike, b: ArrayLike) -> T: ...
@@ -32,7 +32,7 @@ class Sum(_BaseAccumulator):
3232
def __init__(self, value: float | None) -> None: ...
3333
@property
3434
def value(self) -> float: ...
35-
def __iadd__(self: T, val: float, /) -> T: ...
35+
def __iadd__(self: T, arg0: float) -> T: ...
3636
def fill(self: T, value: ArrayLike) -> T: ...
3737
@property
3838
def _small(self) -> float: ...
@@ -63,11 +63,11 @@ class WeightedMean(_BaseAccumulator):
6363
def fill(self: T, value: ArrayLike, *, weight: ArrayLike | None = None) -> T: ...
6464
@staticmethod
6565
def _make(
66-
self: T, a: ArrayLike, b: ArrayLike, c: ArrayLike, d: ArrayLike, /
66+
self: T, arg0: ArrayLike, arg1: ArrayLike, arg2: ArrayLike, arg3: ArrayLike
6767
) -> T: ...
6868
@staticmethod
6969
def _array(
70-
self: T, a: ArrayLike, b: ArrayLike, c: ArrayLike, d: ArrayLike, /
70+
self: T, arg0: ArrayLike, arg1: ArrayLike, arg2: ArrayLike, arg3: ArrayLike
7171
) -> T: ...
7272
def __getitem__(self, key: str) -> float: ...
7373
def __setitem__(self, key: str, value: float) -> None: ...
@@ -87,12 +87,8 @@ class Mean(_BaseAccumulator):
8787
) -> T: ...
8888
def fill(self: T, value: ArrayLike, *, weight: ArrayLike | None = None) -> T: ...
8989
@staticmethod
90-
def _make(
91-
self: T, a: ArrayLike, b: ArrayLike, c: ArrayLike, d: ArrayLike, /
92-
) -> T: ...
90+
def _make(self: T, arg0: ArrayLike, arg1: ArrayLike, arg2: ArrayLike) -> T: ...
9391
@staticmethod
94-
def _array(
95-
self: T, a: ArrayLike, b: ArrayLike, c: ArrayLike, d: ArrayLike, /
96-
) -> T: ...
92+
def _array(self: T, arg0: ArrayLike, arg1: ArrayLike, arg2: ArrayLike) -> T: ...
9793
def __getitem__(self, key: str) -> float: ...
9894
def __setitem__(self, key: str, value: float) -> None: ...

tests/test_accumulators.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def test_mean():
9494

9595

9696
float_st = st.floats(
97-
allow_nan=False, allow_infinity=False, min_value=-1e5, max_value=1e5
97+
allow_nan=False, allow_infinity=False, min_value=-1e4, max_value=1e4
9898
)
9999
simple_list_st = st.lists(float_st, min_size=1, max_size=10)
100100

@@ -129,7 +129,7 @@ def test_sum_mean(list1, list2):
129129
st.lists(float_st, min_size=n, max_size=n),
130130
st.lists(
131131
st.floats(
132-
allow_nan=False, allow_infinity=False, min_value=1e-2, max_value=1e3
132+
allow_nan=False, allow_infinity=False, min_value=1e-2, max_value=1e2
133133
),
134134
min_size=n,
135135
max_size=n,
@@ -151,12 +151,12 @@ def test_sum_weighed_mean(pair1, pair2):
151151

152152
ab = a + b
153153
assert ab.value == approx(c.value)
154-
assert ab.variance == approx(c.variance, nan_ok=True, abs=1e-7, rel=1e-3)
154+
assert ab.variance == approx(c.variance, nan_ok=True, abs=1e-3, rel=1e-2)
155155
assert ab.sum_of_weights == approx(c.sum_of_weights)
156156
assert ab.sum_of_weights_squared == approx(c.sum_of_weights_squared)
157157

158158
a += b
159159
assert a.value == approx(c.value)
160-
assert a.variance == approx(c.variance, nan_ok=True, abs=1e-7, rel=1e-3)
160+
assert a.variance == approx(c.variance, nan_ok=True, abs=1e-3, rel=1e-2)
161161
assert a.sum_of_weights == approx(c.sum_of_weights)
162162
assert a.sum_of_weights_squared == approx(c.sum_of_weights_squared)

0 commit comments

Comments
 (0)