Custom format validation #5
Conversation
src/Form/State.elm
Outdated
| -} | ||
| type alias Settings = | ||
| { customFormats : Dict String (String -> Result String String) |
There was a problem hiding this comment.
As we discussed, returning an error may be an overkill. Perhaps return Result () String?
src/Form/Validation.elm
Outdated
| |> Maybe.map (\validation -> validation value) | ||
| |> Maybe.withDefault (Result.Ok value) | ||
| in | ||
| Result.mapError (\err -> error (Error.InvalidCustomFormat err)) customValidation |
There was a problem hiding this comment.
I think it'd be good to report customFormat, not err, in Error.InvalidCustomFormat. Our front-end may want to show a hint corresponding to which Personal number was requested (similar to what ID Check does):
| Result.mapError (\err -> error (Error.InvalidCustomFormat err)) customValidation | |
| Result.mapError (\_ -> error (Error.InvalidCustomFormat customFormat)) customValidation |
| "not the correct format" | ||
|
|
||
| InvalidCustomFormat _ -> | ||
| "not the correct format" |
There was a problem hiding this comment.
@potocpav Shall we by the way give more information here regarding which format it is (which we underscore now) or leave is same as InvalidFormat?
There was a problem hiding this comment.
I don't think we should. The format string is internal, and should not be present in the UI. If users want to see more info, they need to implement their own view.
Added settings that contain provided custom format for validations.