Documentation improvements regarding typesafety of "equals" and "same"

[DBX12]

While working with codeception/verify, I've realized that equals does not assert the types of the variables but same does. I've already opened a PR there and got informed that this change should be made first in phpunit itself.

What is your position on this? If you think the changes I made in codeception/verify are beneficial in phpunit as well, I'd happily provide a PR for it.

Did I catch all relevant locations?

• assertEquals and similar functions in src/Framework/Assert/Functions.php:385-437
• assertNotEquals and similar functions in src/Framework/Assert/Functions.php:439-501
• Assert::equals and similar functions in src/Framework/Assert.php:387-431
• Assert::notEquals and similar functions in src/Framework/Assert.php:438-490

[sebastianbergmann]

Sorry, I was confused fas I saw "Documentation" in the title and thought "this belongs in the documentation repository".

Sure, we can improve that. If we do, then any improvement should not be limited to comments in the code (which I personally never look at) but should also include the actual documentation.

[Bilge]

It's not just the case that equals ignores types; it does a loose equality comparison (==); the meaning of which changes depending on the operands.

$date = '2000-01-01';
Assert::assertEquals($a = new DateTime($date), $b = new DateTime($date)); // true
Assert::assertSame($a, $b); // false