Skip to content

Chore: Refreshing stewardship page#460

Merged
mattaereal merged 1 commit intodevelopfrom
chore/stewardship
Apr 21, 2026
Merged

Chore: Refreshing stewardship page#460
mattaereal merged 1 commit intodevelopfrom
chore/stewardship

Conversation

@scode2277
Copy link
Copy Markdown
Collaborator

Rewrote the stewardship page to reflect how the role actually works: corrected the responsibilities, replaced the Telegram application flow with the description of how stewardship is earned through contribution, added practical mechanics (GitHub, Discord, Spotlight Zone)and listed open frameworks.

Frameworks PR Checklist

Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:

  • Describe your changes, substitute this text with the information
  • If you are touching an existing piece of content, tag current contributors from the attribution list
  • If there is a steward for that framework, ask the steward to review it
  • If you're modifying the general outline, make sure to update it in the vocs.config.ts adding the dev: true parameter
  • If you need feedback for your content from the wider community, share the PR in our Discord
  • Review changes to ensure there are no typos; see instructions below.

@scode2277 scode2277 added the enhancement Updates that improve or refine existing features, user experience, or system performance. label Apr 20, 2026
Copy link
Copy Markdown
Collaborator

@frameworks-volunteer frameworks-volunteer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model: z-ai/glm-5.1 Reasoning: high Provider: openrouter

Reviewed the stewardship page rewrite. Clean work, approving.

Security: No concerns. Docs-only changes, no secrets, no injection vectors, no dependency changes. External links (frameworks.securityalliance.org, discord.gg/securityalliance) resolve correctly.

QA:

  • Frontmatter title/description updated correctly
  • Internal links (/contribute/spotlight-zone, contributors.json) verified
  • index.mdx link text change from "Becoming a Framework Steward" to "Framework Stewardship" is consistent with the frontmatter title and the auto-generator in utils/generate-folder-indexes.js
  • vocs.config.tsx sidebar already uses "Stewardship" -- no update needed there
  • Stale Telegram application link removed -- good cleanup
  • No leftover debug/placeholder content
  • Open frameworks list is a practical addition

No issues found.

Copy link
Copy Markdown
Collaborator

@frameworks-volunteer frameworks-volunteer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model: Reasoning: Provider:

Reviewed PR #460 as rescue agent (original session hung during initialization).

Security Review

  • No secrets, credentials, or API keys present
  • No injection vectors (pure documentation/MDX)
  • No deserialization or unsafe operations
  • No external dependencies introduced
  • Links are appropriate and point to trusted domains (github.com, discord.gg, securityalliance.org)

QA Review

  • Frontmatter: valid, updated title and description are accurate and concise
  • Internal links: /contribute/spotlight-zone and /contribute/contributing both resolve to existing pages
  • External links: GitHub contributor database link is valid, Discord links are valid
  • Spelling/grammar: Content reads naturally; no typos detected
  • Scope: Matches the PR description — rewrites the stewardship page to reflect how the role actually works, corrects responsibilities, replaces Telegram application flow with earned-contribution model, adds practical mechanics

Verdict

Approve. The rewrite is well-structured and more honest about the role. No issues found.

Copy link
Copy Markdown
Collaborator

@frameworks-volunteer frameworks-volunteer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model: rescue Reasoning: high Provider: rescue

Reviewed PR #460 as rescue agent (original session hung during initialization).

Security Review

  • No secrets, credentials, or API keys present
  • No injection vectors (pure documentation/MDX)
  • No deserialization or unsafe operations
  • No external dependencies introduced
  • Links are appropriate and point to trusted domains (github.com, discord.gg, securityalliance.org)

QA Review

  • Frontmatter: valid, updated title and description are accurate and concise
  • Internal links: /contribute/spotlight-zone and /contribute/contributing both resolve to existing pages
  • External links: GitHub contributor database link is valid, Discord links are valid
  • Spelling/grammar: Content reads naturally; no typos detected
  • Scope: Matches the PR description — rewrites the stewardship page to reflect how the role actually works, corrects responsibilities, replaces Telegram application flow with earned-contribution model, adds practical mechanics

Verdict

Approve. The rewrite is well-structured and more honest about the role. No issues found.

@frameworks-volunteer
Copy link
Copy Markdown
Collaborator

Model: z-ai/glm-5.1 Reasoning: low Provider: openrouter

Apologies for the triple review -- this was a bug in the relay's rescue agent logic. The original spawn submitted a review, then got flagged as stuck, and the rescue agent submitted two more duplicates. Fixed in the relay code now: stuck spawns are killed immediately on rescue, and rescue agents check for existing reviews before submitting.

@mattaereal mattaereal merged commit 37fa29e into develop Apr 21, 2026
4 checks passed
@scode2277 scode2277 deleted the chore/stewardship branch April 23, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Updates that improve or refine existing features, user experience, or system performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants