feat(CSAF2.1): #403 add mandatory test 6.2.39.4

Author: rainer-exxcellent

README.md

@@ -462,6 +462,7 @@ export const recommendedTest_6_2_18: DocumentTest
 export const recommendedTest_6_2_22: DocumentTest
 export const recommendedTest_6_2_23: DocumentTest
 export const recommendedTest_6_2_39_2: DocumentTest
+export const recommendedTest_6_2_39_4: DocumentTest
 ```
 
 [(back to top)](#bsi-csaf-validator-lib)

csaf_2_1/recommendedTests.js

@@ -33,3 +33,4 @@ export { recommendedTest_6_2_28 } from './recommendedTests/recommendedTest_6_2_2
 export { recommendedTest_6_2_29 } from './recommendedTests/recommendedTest_6_2_29.js'
 export { recommendedTest_6_2_38 } from './recommendedTests/recommendedTest_6_2_38.js'
 export { recommendedTest_6_2_39_2 } from './recommendedTests/recommendedTest_6_2_39_2.js'
+export { recommendedTest_6_2_39_4 } from './recommendedTests/recommendedTest_6_2_39_4.js'

csaf_2_1/recommendedTests/recommendedTest_6_2_39_4.js

@@ -0,0 +1,105 @@
+import Ajv from 'ajv/dist/jtd.js'
+import {
+  existsReferenceWithSummaryAndCategory,
+  getTranslationInDocumentLang,
+  isLangSpecifiedAndNotEnglish,
+} from '../../lib/shared/languageSpecificTranslation.js'
+
+const ajv = new Ajv()
+
+/*
+  This is the jtd schema that needs to match the input document so that the
+  test is activated. If this schema doesn't match it normally means that the input
+  document does not validate against the csaf json schema or optional fields that
+  the test checks are not present.
+ */
+const inputSchema = /** @type {const} */ ({
+  additionalProperties: true,
+  properties: {
+    document: {
+      additionalProperties: true,
+      properties: {
+        category: { type: 'string' },
+      },
+      optionalProperties: {
+        lang: {
+          type: 'string',
+        },
+        references: {
+          elements: {
+            additionalProperties: true,
+            optionalProperties: {
+              category: {
+                type: 'string',
+              },
+              references: {
+                type: 'string',
+              },
+            },
+          },
+        },
+      },
+    },
+  },
+})
+
+const validateSchema = ajv.compile(inputSchema)
+
+/**
+ * If the document language is specified but not English, it MUST be tested that at least one item in document
+ * references exists that starts with the language-specific translation of the term Superseding Document as summary.
+ * The category of this item MUST be external. If no language-specific translation has been recorded,
+ * the test MUST be skipped and output an information to the user that no such translation is known.
+ *
+ * @param {unknown} doc
+ */
+export function recommendedTest_6_2_39_4(doc) {
+  /*
+        The `ctx` variable holds the state that is accumulated during the test run and is
+        finally returned by the function.
+       */
+  const ctx = {
+    warnings:
+      /** @type {Array<{ instancePath: string; message: string }>} */ ([]),
+  }
+
+  const referenceCategory = 'external'
+
+  if (!validateSchema(doc) || doc.document.category !== 'csaf_superseded') {
+    return ctx
+  }
+
+  const supersedingInDocLang = getTranslationInDocumentLang(
+    doc,
+    'superseding_document'
+  )
+  if (!supersedingInDocLang) {
+    ctx.warnings.push({
+      instancePath: '/document/references',
+      message:
+        'no language specific translation for "Superseding Document" has been recorded',
+    })
+    return ctx
+  }
+
+  if (isLangSpecifiedAndNotEnglish(doc.document.lang)) {
+    const references = doc.document.references
+    if (
+      !references ||
+      !existsReferenceWithSummaryAndCategory(
+        references,
+        supersedingInDocLang,
+        referenceCategory
+      )
+    ) {
+      ctx.warnings.push({
+        instancePath: '/document/references',
+        message:
+          `for document category "csaf_superseded" at least one references must exist ` +
+          `with reference category "${referenceCategory}" and whose summary begins with  ${supersedingInDocLang}`,
+      })
+    }
+  }
+
+  return ctx
+}

lib/shared/languageSpecificTranslation.js

@@ -32,6 +32,29 @@ export function containsOneNoteWithTitleAndCategory(
   )
 }
 
+/**
+ *  test whether at least one item in document references exists that starts with the given summary
+ *  and has the given category.
+ * @param {({} & { category?: string | undefined; summary?: string | undefined; } & Record<string, unknown>)[]} references
+ * @param {string} summaryStartsWith
+ * @param {string} category
+ * @returns {boolean} True if the reference was found, false otherwise
+ */
+export function existsReferenceWithSummaryAndCategory(
+  references,
+  summaryStartsWith,
+  category
+) {
+  return (
+    references.filter(
+      (reference) =>
+        reference.category === category &&
+        reference.summary &&
+        reference.summary.startsWith(summaryStartsWith)
+    ).length > 0
+  )
+}
+
 /**
  * Get the language specific translation of the given i18nKey
  * @param {{ document: { lang?: string; }; }} doc

tests/csaf_2_1/oasis.js

@@ -49,7 +49,6 @@ const excluded = [
   '6.2.37',
   '6.2.39.1',
   '6.2.39.3',
-  '6.2.39.4',
   '6.2.40',
   '6.2.41',
   '6.2.42',

tests/csaf_2_1/recommendedTest_6_2_39_4.js

@@ -0,0 +1,34 @@
+import { recommendedTest_6_2_39_4 } from '../../csaf_2_1/recommendedTests/recommendedTest_6_2_39_4.js'
+import { expect } from 'chai'
+import assert from 'node:assert'
+import { getTranslationInDocumentLang } from '../../lib/shared/languageSpecificTranslation.js'
+
+describe('recommendedTest_6_2_39_4', function () {
+  it('only runs on relevant documents', function () {
+    assert.equal(recommendedTest_6_2_39_4({}).warnings.length, 0)
+  })
+
+  it('only runs on valid language', function () {
+    assert.equal(
+      recommendedTest_6_2_39_4({
+        document: { lang: '123', license_expression: 'MIT' },
+      }).warnings.length,
+      0
+    )
+  })
+
+  it('check get superseding_document in document lang', function () {
+    expect(
+      getTranslationInDocumentLang(
+        { document: { lang: 'de' } },
+        'superseding_document'
+      )
+    ).to.eq('Ersetzendes Dokument')
+    expect(
+      getTranslationInDocumentLang({ document: { lang: 'es' } }, 'v')
+    ).to.eq(undefined)
+    expect(
+      getTranslationInDocumentLang({ document: {} }, 'superseding_document')
+    ).to.eq(undefined)
+  })
+})