refactor translation utils

Author: domachine

lib/shared/languageSpecificTranslation.js

@@ -1,3 +1,13 @@
+import bcp47 from 'bcp47'
+import translations from '../../lib/language_specific_translation/translations.js'
+
+const translationMap = new Map(
+  Object.entries(translations.translation).map(([key, value]) => [
+    key,
+    new Map(Object.entries(value)),
+  ])
+)
+
 /**
  * Checks if the document language is specified and not English
  *
@@ -9,13 +19,11 @@ export function isLangSpecifiedAndNotEnglish(language) {
     !!language && !(bcp47.parse(language)?.langtag.language.language === 'en')
   )
 }
-import bcp47 from 'bcp47'
-import translations from '../../lib/language_specific_translation/translations.js'
 
 /**
  *  test whether exactly one item in document notes exists that has the given title.
  *  and the given category.
- * @param {({} & { category?: string | undefined; title?: string | undefined; } & Record<string, unknown>)[]} notes
+ * @param {Array<{ category?: string | undefined; title?: string | undefined; }>} notes
  * @param {string} titleToFind
  * @param {string} category
  * @returns {boolean} True if the language is valid, false otherwise
@@ -36,19 +44,14 @@ export function containsOneNoteWithTitleAndCategory(
  * Get the language specific translation of the given i18nKey
  * @param {{ document: { lang?: string; }; }} doc
  * @param {string} i18nKey
- * @return {string | undefined}
  */
 export function getTranslationInDocumentLang(doc, i18nKey) {
   if (!doc.document.lang) {
     return undefined
   }
   const language = bcp47.parse(doc.document.lang)?.langtag.language.language
-
-  /** @type {Record<string, Record <string,string>>}*/
-  const translationByLang = translations.translation
-  if (!language || !translationByLang[language]) {
+  if (!language) {
     return undefined
-  } else {
-    return translationByLang[language][i18nKey]
   }
+  return translationMap.get(language)?.get(i18nKey)
 }