Merge pull request #84 from sendbird/v3.2.19

Add 3.2.19.

Author: sf-tyler-jeong

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [3.2.19] - Oct 13, 2023
+
+- Fixed the bug regarding WebSocket error handling.
+
 ## [3.2.18] - Sep 18, 2023
 
 - Fixed the bug regarding uploadSizeLimit

README.md

@@ -3,6 +3,9 @@
 [![Platform](https://img.shields.io/badge/platform-flutter-blue)](https://flutter.dev/)
 [![Language](https://img.shields.io/badge/language-dart-blue)](https://dart.dev/)
 
+> **Warning**
+> Sendbird Chat SDK v3 for Flutter is no longer supported as a new version is released. Check out our latest Chat SDK v4 [here](https://pub.dev/packages/sendbird_chat_sdk)
+
 ## Table of contents
 
 1. [Introduction](#introduction)
@@ -38,8 +41,8 @@ Through Chat SDK for flutter, you can efficiently integrate real-time chat into
 The minimum requirements for Chat SDK for Flutter are:
 
 - Xcode or Android studio
-- Dart 2.10.4 or above
-- Flutter 1.22.0 or higher
+- Dart 2.18.0 or above
+- Flutter 3.3.0 or higher
 
 ## Getting started
 
@@ -71,7 +74,7 @@ Installing the Chat SDK is a simple process if you’re familiar with using exte
 
 ```yaml
 dependencies:
-  sendbird_sdk: ^3.2.18
+  sendbird_sdk: ^3.2.19
 ```
 
 - Run `flutter pub get` command in your project directory.

lib/sdk/internal/sendbird_sdk_internal.dart

@@ -25,7 +25,7 @@ import 'package:flutter/foundation.dart' show kIsWeb;
 
 import '../../constant/contants.dart';
 
-const sdk_version = '3.2.18';
+const sdk_version = '3.2.19';
 const platform = 'flutter';
 
 /// This allows a value of type T or T? to be treated as a value of type T?.
@@ -274,20 +274,31 @@ class SendbirdSdkInternal with WidgetsBindingObserver {
     final fullWsHost = wsHostUrl + '/?' + Uri(queryParameters: params).query;
 
     logger.i('websocket connecting.. ');
-    try {
+    runZonedGuarded(() async {
       await _webSocket?.connect(fullWsHost);
-    } catch (e) {
+    }, (error, stack) {
+      if (_loginCompleter != null && !_loginCompleter!.isCompleted) {
+        _loginCompleter!.completeError(error);
+      }
+
       _state.connecting = false;
       _state.reconnecting = false;
       _loginCompleter = null;
       _forceReconnect = false;
-      rethrow;
-    }
+    });
 
     final user = await _loginCompleter!.future.timeout(
         Duration(seconds: options.connectionTimeout), onTimeout: () async {
       logger.e('login timeout');
       throw LoginTimeoutError();
+    }).onError((error, stackTrace) {
+      if (error is SBError) {
+        throw error;
+      } else if (error is Exception) {
+        throw WebSocketError(message: error.toString());
+      } else {
+        throw WebSocketConnectionFailed();
+      }
     });
 
     logger.i('websocket connected and get user from sendbird server');

lib/services/network/websocket_client.dart

@@ -95,18 +95,20 @@ class WebSocketClient {
 
     _stopPing();
 
-    try {
+    bool result = false;
+    runZonedGuarded(() async {
       //This should trigger callback for Done()
       //And set _connected to false before returning from close
       await _socket?.sink.close(code, reason);
-      _subscription?.cancel();
-      _socket = null;
       logger.i('Socket closed ' + reason);
-      return true;
-    } catch (e) {
-      onReceiveError(e);
-      return false;
-    }
+      result = true;
+    }, (error, stack) {
+      onReceiveError(error);
+    });
+
+    _subscription?.cancel();
+    _socket = null;
+    return result;
   }
 
   void send(String data) {

pubspec.yaml

@@ -1,6 +1,6 @@
 name: sendbird_sdk
 description: The Flutter SDK for Sendbird Chat brings modern messenger chat features to your iOS and Android deployments
-version: 3.2.18
+version: 3.2.19
 homepage: https://www.sendbird.com
 repository: https://www.github.com/sendbird/sendbird-sdk-flutter
 documentation: https://sendbird.com/docs/chat/v3/flutter/quickstart/send-first-message